From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Gortmaker Subject: Re: [PATCH 5/9] iommu: ipmmu-vmsa: make it explicitly non-modular Date: Wed, 28 Nov 2018 17:10:55 -0500 Message-ID: <20181128221054.GJ14659@windriver.com> References: <1543271498-28966-1-git-send-email-paul.gortmaker@windriver.com> <20181128153204.GI14659@windriver.com> <7671106.x9S16LaZuq@avalon> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <7671106.x9S16LaZuq@avalon> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Laurent Pinchart Cc: Robin Murphy , iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: iommu@lists.linux-foundation.org [Re: [PATCH 5/9] iommu: ipmmu-vmsa: make it explicitly non-modular] On 28/11/2018 (Wed 19:22) Laurent Pinchart wrote: > Hi Paul, > > On Wednesday, 28 November 2018 17:32:05 EET Paul Gortmaker wrote: > > [Re: [PATCH 5/9] iommu: ipmmu-vmsa: make it explicitly non-modular] On > 28/11/2018 (Wed 12:50) Robin Murphy wrote: > > > On 26/11/2018 22:31, Paul Gortmaker wrote: > > [...] > > > > >> diff --git a/drivers/iommu/ipmmu-vmsa.c b/drivers/iommu/ipmmu-vmsa.c > > >> index 9e2655f1c1bf..de39ef992d8a 100644 > > >> --- a/drivers/iommu/ipmmu-vmsa.c > > >> +++ b/drivers/iommu/ipmmu-vmsa.c > > >> @@ -1,6 +1,8 @@ > > >> > > >> // SPDX-License-Identifier: GPL-2.0 > > >> /* > > >> * IPMMU VMSA > > > > > > Nit: this line doesn't convey any information that the module description > > > below doesn't also say far more clearly, so you may as well just replace > > > it entirely. > > > > No problem. Will do in v2. > > With that change, the blank line after MODULE_DEVICE_TABLE() removed, and > moved to keep alphabetical order sorting of the includes, > please add > > Reviewed-by: Laurent Pinchart Updated and review tag added for v2. Paul. -- > > to v2. Thank you for the patch. > > > > >+ * IOMMU API for Renesas VMSA-compatible IPMMU > > > >+ * Author: Laurent Pinchart > > > > [...] > > -- > Regards, > > Laurent Pinchart > > >