From mboxrd@z Thu Jan 1 00:00:00 1970 From: Will Deacon Subject: Re: [PATCH 3/9] iommu/arm-smmu: Use helper functions to access dev->iommu_fwspec Date: Thu, 6 Dec 2018 13:11:30 +0000 Message-ID: <20181206131130.GA27744@arm.com> References: <20181204163002.15800-1-joro@8bytes.org> <20181204163002.15800-4-joro@8bytes.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20181204163002.15800-4-joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Joerg Roedel Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, Joerg Roedel , Robin Murphy , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: iommu@lists.linux-foundation.org On Tue, Dec 04, 2018 at 05:29:56PM +0100, Joerg Roedel wrote: > From: Joerg Roedel > > Use the new helpers dev_iommu_fwspec_get()/set() to access > the dev->iommu_fwspec pointer. This makes it easier to move > that pointer later into another struct. > > Cc: Will Deacon > Cc: Robin Murphy > Signed-off-by: Joerg Roedel > --- > drivers/iommu/arm-smmu-v3.c | 16 +++++++++------- > drivers/iommu/arm-smmu.c | 12 ++++++------ > 2 files changed, 15 insertions(+), 13 deletions(-) Looks straighforward enough to me: Acked-by: Will Deacon Will