From: Joerg Roedel <joro@8bytes.org>
To: Robin Murphy <robin.murphy@arm.com>
Cc: iommu@lists.linux-foundation.org, linux-acpi@vger.kernel.org,
linux-kernel@vger.kernel.org, Joerg Roedel <jroedel@suse.de>
Subject: Re: [PATCH 3/4] iommu/of: Don't call iommu_ops->add_device directly
Date: Thu, 6 Dec 2018 17:19:45 +0100 [thread overview]
Message-ID: <20181206161945.GK16835@8bytes.org> (raw)
In-Reply-To: <41d06767-fe6e-a746-d76a-557259af3034@arm.com>
On Wed, Dec 05, 2018 at 06:49:26PM +0000, Robin Murphy wrote:
> if (ops && dev->bus && !dev->iommu_group)
>
> What I can't quite remember just now is whether it's actually valid to get
> here with err == 0 but dev->iommu_fwspec->ops == NULL, so it *might* be OK
> to use "!err" instead of "ops" to make things slightly more obvious - I'll
> work through the flow tomorrow to double-check.
Yeah, adding an err == 0 check seems to be the best option here, so that
iommu-drivers don't get confused when we try to add a device that is not
managed by an iommu.
Regards,
Joerg
next prev parent reply other threads:[~2018-12-06 16:19 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-05 14:36 [PATCH 0/4] Consolitate iommu_ops->add/remove_device() calls Joerg Roedel
2018-12-05 14:36 ` [PATCH 1/4] iommu/sysfs: Rename iommu_release_device() Joerg Roedel
2018-12-05 14:36 ` [PATCH 2/4] iommu: Consolitate ->add/remove_device() calls Joerg Roedel
[not found] ` <20181205143646.4876-3-joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2018-12-05 14:54 ` Christoph Hellwig
2018-12-05 15:14 ` Joerg Roedel
2018-12-05 18:20 ` Robin Murphy
2018-12-06 15:47 ` Joerg Roedel
2018-12-05 14:36 ` [PATCH 3/4] iommu/of: Don't call iommu_ops->add_device directly Joerg Roedel
2018-12-05 18:49 ` Robin Murphy
2018-12-06 16:19 ` Joerg Roedel [this message]
[not found] ` <20181205143646.4876-1-joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2018-12-05 14:36 ` [PATCH 4/4] ACPI/IORT: " Joerg Roedel
-- strict thread matches above, loose matches on Subject: below --
2018-12-11 15:05 [PATCH 0/4 v2] Consolidate iommu_ops->add/remove_device() calls Joerg Roedel
2018-12-11 15:05 ` [PATCH 3/4] iommu/of: Don't call iommu_ops->add_device directly Joerg Roedel
2018-12-19 9:54 ` Marek Szyprowski
2018-12-19 14:34 ` Joerg Roedel
2018-12-19 14:53 ` Marek Szyprowski
2018-12-20 9:13 ` Joerg Roedel
2018-12-20 15:42 ` Geert Uytterhoeven
2019-01-11 10:23 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181206161945.GK16835@8bytes.org \
--to=joro@8bytes.org \
--cc=iommu@lists.linux-foundation.org \
--cc=jroedel@suse.de \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).