From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH] dma-mapping: remove a pointless memset in dma_atomic_pool_init Date: Mon, 10 Dec 2018 20:28:07 +0100 Message-ID: <20181210192807.GA31476@lst.de> References: <20181204160619.3253-1-hch@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20181204160619.3253-1-hch-jcswGhMUV9g@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Cc: linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org List-Id: iommu@lists.linux-foundation.org ping? On Tue, Dec 04, 2018 at 08:06:19AM -0800, Christoph Hellwig wrote: > We already zero the memory after allocating it from the pool that > this function fills, and having the memset here in this form means > we can't support CMA highmem allocations. > > Signed-off-by: Christoph Hellwig > Reported-by: Russell King - ARM Linux > --- > kernel/dma/remap.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/kernel/dma/remap.c b/kernel/dma/remap.c > index 68a64e3ff6a1..6e784824326f 100644 > --- a/kernel/dma/remap.c > +++ b/kernel/dma/remap.c > @@ -121,7 +121,6 @@ int __init dma_atomic_pool_init(gfp_t gfp, pgprot_t prot) > if (!page) > goto out; > > - memset(page_address(page), 0, atomic_pool_size); > arch_dma_prep_coherent(page, atomic_pool_size); > > atomic_pool = gen_pool_create(PAGE_SHIFT, -1); > -- > 2.19.1 > > _______________________________________________ > iommu mailing list > iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org > https://lists.linuxfoundation.org/mailman/listinfo/iommu ---end quoted text---