From: Joerg Roedel <joro@8bytes.org>
To: John Garry <john.garry@huawei.com>
Cc: robin.murphy@arm.com, will.deacon@arm.com,
linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org,
ganapatrao.kulkarni@cavium.com, hch@lst.de,
m.szyprowski@samsung.com, linuxarm@huawei.com
Subject: Re: [PATCH v4] iommu/dma: Use NUMA aware memory allocations in __iommu_dma_alloc_pages()
Date: Tue, 11 Dec 2018 10:30:30 +0100 [thread overview]
Message-ID: <20181211093030.3x532vs6dwz2ucp7@8bytes.org> (raw)
In-Reply-To: <1543576440-222098-1-git-send-email-john.garry@huawei.com>
On Fri, Nov 30, 2018 at 07:14:00PM +0800, John Garry wrote:
> From: Ganapatrao Kulkarni <ganapatrao.kulkarni@cavium.com>
>
> Change function __iommu_dma_alloc_pages() to allocate pages for DMA from
> respective device NUMA node. The ternary operator which would be for
> alloc_pages_node() is tidied along with this.
>
> The motivation for this change is to have a policy for page allocation
> consistent with direct DMA mapping, which attempts to allocate pages local
> to the device, as mentioned in [1].
>
> In addition, for certain workloads it has been observed a marginal
> performance improvement. The patch caused an observation of 0.9% average
> throughput improvement for running tcrypt with HiSilicon crypto engine.
>
> We also include a modification to use kvzalloc() for kzalloc()/vzalloc()
> combination.
>
> [1] https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1692998.html
>
> Signed-off-by: Ganapatrao Kulkarni <ganapatrao.kulkarni@cavium.com>
> [JPG: Added kvzalloc(), drop pages ** being device local, remove ternary operator, update message]
> Signed-off-by: John Garry <john.garry@huawei.com>
Applied, thanks.
prev parent reply other threads:[~2018-12-11 9:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-30 11:14 [PATCH v4] iommu/dma: Use NUMA aware memory allocations in __iommu_dma_alloc_pages() John Garry
2018-12-07 17:57 ` John Garry
[not found] ` <df449701-5ecb-26c7-cb17-b3fe03cc29e7-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2018-12-10 9:05 ` Joerg Roedel
2018-12-10 12:03 ` Robin Murphy
2018-12-11 9:30 ` Joerg Roedel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181211093030.3x532vs6dwz2ucp7@8bytes.org \
--to=joro@8bytes.org \
--cc=ganapatrao.kulkarni@cavium.com \
--cc=hch@lst.de \
--cc=iommu@lists.linux-foundation.org \
--cc=john.garry@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=m.szyprowski@samsung.com \
--cc=robin.murphy@arm.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox