iommu.lists.linux-foundation.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Sibren Vasse <sibren@sibrenvasse.nl>
Cc: "Sibren Vasse" <freedesktop@sibrenvasse.nl>,
	"Konrad Rzeszutek Wilk" <konrad.wilk@oracle.com>,
	"Michel Dänzer" <michel@daenzer.net>,
	x86@kernel.org, dri-devel@lists.freedesktop.org,
	iommu@lists.linux-foundation.org, amd-gfx@lists.freedesktop.org,
	"Robin Murphy" <robin.murphy@arm.com>,
	"Christoph Hellwig" <hch@lst.de>,
	"Marek Szyprowski" <m.szyprowski@samsung.com>
Subject: Re: amdgpu/TTM oopses since merging swiotlb_dma_ops into the dma_direct code
Date: Mon, 14 Jan 2019 19:13:14 +0100	[thread overview]
Message-ID: <20190114181314.GC8897@lst.de> (raw)
In-Reply-To: <CAF=iVctGGs1OzHBg6MgpxrFbT_19T4YvH8muBZtsLJBDwGhrvQ@mail.gmail.com>

Hmm, I wonder if we are not actually using swiotlb in the end,
can you check if your dmesg contains this line or not?

PCI-DMA: Using software bounce buffering for IO (SWIOTLB)

If not I guess we found a bug in swiotlb exit vs is_swiotlb_buffer,
and you can try this patch:

diff --git a/kernel/dma/swiotlb.c b/kernel/dma/swiotlb.c
index d6361776dc5c..1fb6fd68b9c7 100644
--- a/kernel/dma/swiotlb.c
+++ b/kernel/dma/swiotlb.c
@@ -378,6 +378,8 @@ void __init swiotlb_exit(void)
 		memblock_free_late(io_tlb_start,
 				   PAGE_ALIGN(io_tlb_nslabs << IO_TLB_SHIFT));
 	}
+	io_tlb_start = 0;
+	io_tlb_end = 0;
 	io_tlb_nslabs = 0;
 	max_segment = 0;
 }
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2019-01-14 18:13 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-10  9:59 amdgpu/TTM oopses since merging swiotlb_dma_ops into the dma_direct code Michel Dänzer
2019-01-10 13:57 ` Christoph Hellwig
2019-01-10 14:00   ` Christian König
     [not found]     ` <a3f0fd49-2286-ee2a-f0e8-dfe82aac73fb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2019-01-10 14:48       ` Christoph Hellwig
     [not found]         ` <20190110144837.GA10362-jcswGhMUV9g@public.gmane.org>
2019-01-10 17:52           ` Sibren Vasse
2019-01-14 18:10             ` Christoph Hellwig
     [not found]               ` <20190114181041.GB8897-jcswGhMUV9g@public.gmane.org>
2019-01-14 19:00                 ` Sibren Vasse
2019-01-14 17:22           ` Michel Dänzer
     [not found]   ` <20190110135741.GA9255-jcswGhMUV9g@public.gmane.org>
2019-01-10 15:26     ` Sibren Vasse
     [not found]       ` <CAF=iVctGGs1OzHBg6MgpxrFbT_19T4YvH8muBZtsLJBDwGhrvQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2019-01-10 17:05         ` Konrad Rzeszutek Wilk
     [not found]           ` <20190110170557.GD27546-he5eyhs8q0BAdwtm4QZOy9BPR1lH4CV8@public.gmane.org>
2019-01-10 17:34             ` Sibren Vasse
2019-01-14 18:13       ` Christoph Hellwig [this message]
     [not found]         ` <20190114181314.GC8897-jcswGhMUV9g@public.gmane.org>
2019-01-14 19:32           ` Sibren Vasse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190114181314.GC8897@lst.de \
    --to=hch@lst.de \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=freedesktop@sibrenvasse.nl \
    --cc=iommu@lists.linux-foundation.org \
    --cc=konrad.wilk@oracle.com \
    --cc=m.szyprowski@samsung.com \
    --cc=michel@daenzer.net \
    --cc=robin.murphy@arm.com \
    --cc=sibren@sibrenvasse.nl \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).