From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joerg Roedel Subject: Re: MT76x2U crashes XHCI driver on AMD Ryzen system Date: Tue, 26 Feb 2019 11:05:36 +0100 Message-ID: <20190226100535.GA20740@8bytes.org> References: <83A1D243-9073-48D1-9F26-5A2581DCB829@gmail.com> <1547404075.1582.0@smtp.gmail.com> <20190114091841.GA23045@localhost.localdomain> <20190115090400.GA2267@localhost.localdomain> <20190218143742.GA11872@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20190218143742.GA11872-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> Sender: linux-wireless-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Stanislaw Gruszka Cc: Lorenzo Bianconi , Rosen Penev , linux-wireless , Samuel Sieb , Alexander Duyck , iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: iommu@lists.linux-foundation.org On Mon, Feb 18, 2019 at 03:37:48PM +0100, Stanislaw Gruszka wrote: > 0001-mt76x02u-use-usb_bulk_msg-to-upload-firmware.patch > 0002-mt76usb-do-not-use-compound-head-page-for-SG-I-O.patch > > Or problem can be solved by just one of it (either first or second). > > Additionally I'm not 100% sure if > > 0002-mt76usb-do-not-use-compound-head-page-for-SG-I-O.patch > > is correct. So perhaps some IOMMU maintainer could look at it. The patch looks good, but I don't understand why it is needed. The AMD IOMMU driver should handle sg->offset > PAGE_SIZE just fine. Can you verify that this is the problem? I will look into that again if it turns out there is bug in the IOMMU driver. Regards, Joerg