From: Jacob Pan <jacob.jun.pan-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
To: James Sewart <jamessewart-nzgTgzXrdUbQT0dZR+AlfA@public.gmane.org>
Cc: Dmitry Safonov <dima-nzgTgzXrdUbQT0dZR+AlfA@public.gmane.org>,
Tom Murphy <tmurphy-nzgTgzXrdUbQT0dZR+AlfA@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org
Subject: Re: [PATCH v2 7/7] iommu/vt-d: Remove lazy allocation of domains
Date: Thu, 14 Mar 2019 16:35:01 -0700 [thread overview]
Message-ID: <20190314163501.2f414a78@jacob-builder> (raw)
In-Reply-To: <F4D76093-3F9F-4184-9F92-191A01126D0F-nzgTgzXrdUbQT0dZR+AlfA@public.gmane.org>
On Thu, 14 Mar 2019 11:59:36 +0000
James Sewart <jamessewart-nzgTgzXrdUbQT0dZR+AlfA@public.gmane.org> wrote:
>
> - domain = get_valid_domain_for_dev(dev);
> + domain = find_domain(dev);
> if (!domain)
> return DMA_MAPPING_ERROR;
>
> @@ -3914,7 +3624,7 @@ static int intel_map_sg(struct device *dev,
> struct scatterlist *sglist, int nele if (iommu_no_mapping(dev))
> return intel_nontranslate_map_sg(dev, sglist,
> nelems, dir);
> - domain = get_valid_domain_for_dev(dev);
> + domain = find_domain(dev);
This patchset looks like a very good clean up, I am wondering why we
can't use the generic iommu_get_domain_for_dev() here, since VT-d has a
default DMA domain after your patch.
next prev parent reply other threads:[~2019-03-14 23:35 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-04 15:41 [PATCH 0/4] iommu/vt-d: Fix-up device-domain relationship by refactoring to use iommu group default domain James Sewart
2019-03-04 15:45 ` [PATCH 1/4] iommu: Move iommu_group_create_direct_mappings to after device_attach James Sewart
2019-03-04 15:46 ` [PATCH 2/4] iommu/vt-d: Implement apply_resv_region for reserving IOVA ranges James Sewart
2019-03-04 15:46 ` [PATCH 3/4] iommu/vt-d: Allow IOMMU_DOMAIN_DMA and IOMMU_DOMAIN_IDENTITY to be allocated James Sewart
2019-03-04 15:47 ` [PATCH 4/4] iommu/vt-d: Remove lazy allocation of domains James Sewart
2019-03-05 6:59 ` Lu Baolu
2019-03-05 11:46 ` James Sewart
[not found] ` <4B054B40-0B13-4F1E-87D6-8D2F072B5B9C-nzgTgzXrdUbQT0dZR+AlfA@public.gmane.org>
2019-03-06 7:00 ` Lu Baolu
[not found] ` <06aa306a-278a-a22f-7718-200f6f9e5e87-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2019-03-06 18:08 ` James Sewart via iommu
[not found] ` <A8A495EE-D3EA-4D84-AB92-9B4742E6E500-nzgTgzXrdUbQT0dZR+AlfA@public.gmane.org>
2019-03-07 6:31 ` Lu Baolu
2019-03-07 10:21 ` James Sewart
2019-03-08 1:09 ` Lu Baolu
2019-03-08 3:09 ` Lu Baolu
2019-03-08 16:57 ` James Sewart
2019-03-09 1:53 ` Lu Baolu
2019-03-09 11:49 ` James Sewart
[not found] ` <A7A831AB-A7A0-407F-A7E3-B84E354E9986-nzgTgzXrdUbQT0dZR+AlfA@public.gmane.org>
2019-03-10 2:51 ` Lu Baolu
2019-03-05 6:46 ` [PATCH 3/4] iommu/vt-d: Allow IOMMU_DOMAIN_DMA and IOMMU_DOMAIN_IDENTITY to be allocated Lu Baolu
2019-03-05 11:34 ` James Sewart
[not found] ` <F83456DB-81DD-4E9B-9204-12ED9972D2FA-nzgTgzXrdUbQT0dZR+AlfA@public.gmane.org>
2019-03-08 1:20 ` Dmitry Safonov via iommu
2019-03-09 11:57 ` James Sewart
2019-03-05 6:05 ` [PATCH 0/4] iommu/vt-d: Fix-up device-domain relationship by refactoring to use iommu group default domain Lu Baolu
2019-03-05 11:14 ` James Sewart
2019-03-06 6:27 ` Lu Baolu
2019-03-14 11:56 ` [PATCH v2 0/7] " James Sewart
[not found] ` <83B82113-8AE5-4B0C-A079-F389520525BD-nzgTgzXrdUbQT0dZR+AlfA@public.gmane.org>
2019-03-14 11:57 ` [PATCH v2 1/7] iommu: Move iommu_group_create_direct_mappings to after device_attach James Sewart via iommu
2019-03-14 11:59 ` [PATCH v2 6/7] iommu/vt-d: Allow IOMMU_DOMAIN_DMA to be allocated by iommu_ops James Sewart via iommu
2019-03-14 11:58 ` [PATCH v2 2/7] iommu/vt-d: Implement apply_resv_region for reserving IOVA ranges James Sewart
2019-03-14 11:58 ` [PATCH v2 3/7] iommu/vt-d: Expose ISA direct mapping region via iommu_get_resv_regions James Sewart
2019-03-15 2:19 ` Lu Baolu
2019-03-22 9:57 ` James Sewart
[not found] ` <A489539F-4DD4-438A-AD9A-1A2F50404DB9-nzgTgzXrdUbQT0dZR+AlfA@public.gmane.org>
2019-03-25 2:03 ` Lu Baolu
2019-03-25 12:57 ` James Sewart
[not found] ` <445F31EA-20F3-481C-B1DF-8B163791FF8C-nzgTgzXrdUbQT0dZR+AlfA@public.gmane.org>
2019-03-26 1:10 ` Lu Baolu
2019-03-26 1:24 ` Lu Baolu
2019-03-28 18:37 ` James Sewart
2019-03-29 15:26 ` James Sewart
2019-04-04 6:49 ` Lu Baolu
2019-04-05 18:02 ` James Sewart
2019-04-05 18:02 ` James Sewart via iommu
[not found] ` <9AECB54A-2DA7-4ABD-A9B5-0549E108D1AF-nzgTgzXrdUbQT0dZR+AlfA@public.gmane.org>
2019-04-08 2:43 ` Lu Baolu
2019-04-08 2:43 ` Lu Baolu
2019-04-10 5:22 ` Lu Baolu
2019-04-10 5:22 ` Lu Baolu
2019-04-15 14:16 ` James Sewart
2019-04-15 14:16 ` James Sewart via iommu
2019-04-16 2:18 ` Lu Baolu
2019-04-16 2:18 ` Lu Baolu
2019-04-24 23:47 ` Tom Murphy
2019-04-24 23:47 ` Tom Murphy via iommu
[not found] ` <CAPL0++4w6TDf38fh6LwAADR1w3b+nO5G7rZFM3LjDE-B20zbow-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2019-04-25 1:15 ` Lu Baolu
2019-04-25 1:15 ` Lu Baolu
2019-03-14 11:58 ` [PATCH v2 4/7] iommu/vt-d: Ignore domain parameter in attach_device if device requires identity map James Sewart
2019-03-15 2:30 ` Lu Baolu
2019-03-14 11:58 ` [PATCH v2 5/7] iommu/vt-d: Enable DMA remapping after rmrr mapped James Sewart
2019-03-14 11:59 ` [PATCH v2 7/7] iommu/vt-d: Remove lazy allocation of domains James Sewart
[not found] ` <F4D76093-3F9F-4184-9F92-191A01126D0F-nzgTgzXrdUbQT0dZR+AlfA@public.gmane.org>
2019-03-14 23:35 ` Jacob Pan [this message]
2019-03-22 10:07 ` James Sewart
2019-03-15 3:13 ` [PATCH v2 0/7] iommu/vt-d: Fix-up device-domain relationship by refactoring to use iommu group default domain Lu Baolu
2019-03-19 13:35 ` James Sewart
2019-03-20 1:26 ` Lu Baolu
2019-03-22 10:05 ` James Sewart
[not found] ` <0359F732-374F-4EDB-B49C-14B2F1BB637D-nzgTgzXrdUbQT0dZR+AlfA@public.gmane.org>
2019-03-25 2:16 ` Lu Baolu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190314163501.2f414a78@jacob-builder \
--to=jacob.jun.pan-vuqaysv1563yd54fqh9/ca@public.gmane.org \
--cc=dima-nzgTgzXrdUbQT0dZR+AlfA@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=jamessewart-nzgTgzXrdUbQT0dZR+AlfA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=tmurphy-nzgTgzXrdUbQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox