From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jacob Pan Subject: Re: [PATCH 09/18] iommu/vt-d: Enlightened PASID allocation Date: Tue, 9 Apr 2019 09:34:13 -0700 Message-ID: <20190409093413.603b5333@jacob-builder> References: <1554767973-30125-1-git-send-email-jacob.jun.pan@linux.intel.com> <1554767973-30125-10-git-send-email-jacob.jun.pan@linux.intel.com> <20190409100859.GF9224@smile.fi.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20190409100859.GF9224@smile.fi.intel.com> Sender: linux-kernel-owner@vger.kernel.org To: Andriy Shevchenko Cc: iommu@lists.linux-foundation.org, LKML , Joerg Roedel , David Woodhouse , Alex Williamson , Jean-Philippe Brucker , Yi Liu , "Tian, Kevin" , Raj Ashok , Christoph Hellwig , Lu Baolu , jacob.jun.pan@linux.intel.com List-Id: iommu@lists.linux-foundation.org On Tue, 9 Apr 2019 13:08:59 +0300 Andriy Shevchenko wrote: > On Mon, Apr 08, 2019 at 04:59:24PM -0700, Jacob Pan wrote: > > From: Lu Baolu > > > > If Intel IOMMU runs in caching mode, a.k.a. virtual IOMMU, the > > IOMMU driver should rely on the emulation software to allocate > > and free PASID IDs. The Intel vt-d spec revision 3.0 defines a > > register set to support this. This includes a capability register, > > a virtual command register and a virtual response register. Refer > > to section 10.4.42, 10.4.43, 10.4.44 for more information. > > > > This patch adds the enlightened PASID allocation/free interfaces > > via the virtual command register. > > > + pr_debug("vcmd alloc pasid\n"); > > Perhaps tracepoints should be in use? > OTOH we have function tracer, so, this message in any case is a noise. > And this is applicable to other similar cases. > Agreed, I added that for debug purpose. Thanks, Jacob From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26AA9C10F0E for ; Tue, 9 Apr 2019 16:31:41 +0000 (UTC) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 00ED32084F for ; Tue, 9 Apr 2019 16:31:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 00ED32084F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id CF109D05; Tue, 9 Apr 2019 16:31:40 +0000 (UTC) Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id CB229CE5 for ; Tue, 9 Apr 2019 16:31:39 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 7A4BFF4 for ; Tue, 9 Apr 2019 16:31:39 +0000 (UTC) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Apr 2019 09:31:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,329,1549958400"; d="scan'208";a="147810650" Received: from jacob-builder.jf.intel.com (HELO jacob-builder) ([10.7.199.155]) by FMSMGA003.fm.intel.com with ESMTP; 09 Apr 2019 09:31:38 -0700 Date: Tue, 9 Apr 2019 09:34:13 -0700 From: Jacob Pan To: Andriy Shevchenko Subject: Re: [PATCH 09/18] iommu/vt-d: Enlightened PASID allocation Message-ID: <20190409093413.603b5333@jacob-builder> In-Reply-To: <20190409100859.GF9224@smile.fi.intel.com> References: <1554767973-30125-1-git-send-email-jacob.jun.pan@linux.intel.com> <1554767973-30125-10-git-send-email-jacob.jun.pan@linux.intel.com> <20190409100859.GF9224@smile.fi.intel.com> Organization: OTC X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Cc: "Tian, Kevin" , Raj Ashok , Jean-Philippe Brucker , iommu@lists.linux-foundation.org, LKML , Alex Williamson , David Woodhouse X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Sender: iommu-bounces@lists.linux-foundation.org Errors-To: iommu-bounces@lists.linux-foundation.org Message-ID: <20190409163413.AlHSzTNI6C0r54loEfTLNr3BY1QckL4i4_ouN6dHQJY@z> On Tue, 9 Apr 2019 13:08:59 +0300 Andriy Shevchenko wrote: > On Mon, Apr 08, 2019 at 04:59:24PM -0700, Jacob Pan wrote: > > From: Lu Baolu > > > > If Intel IOMMU runs in caching mode, a.k.a. virtual IOMMU, the > > IOMMU driver should rely on the emulation software to allocate > > and free PASID IDs. The Intel vt-d spec revision 3.0 defines a > > register set to support this. This includes a capability register, > > a virtual command register and a virtual response register. Refer > > to section 10.4.42, 10.4.43, 10.4.44 for more information. > > > > This patch adds the enlightened PASID allocation/free interfaces > > via the virtual command register. > > > + pr_debug("vcmd alloc pasid\n"); > > Perhaps tracepoints should be in use? > OTOH we have function tracer, so, this message in any case is a noise. > And this is applicable to other similar cases. > Agreed, I added that for debug purpose. Thanks, Jacob _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu