From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 12/21] dma-iommu: factor atomic pool allocations into helpers Date: Wed, 17 Apr 2019 08:33:58 +0200 Message-ID: <20190417063358.GA24139@lst.de> References: <20190327080448.5500-1-hch@lst.de> <20190327080448.5500-13-hch@lst.de> <20190410061157.GA5278@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20190410061157.GA5278@lst.de> Sender: linux-kernel-owner@vger.kernel.org To: Robin Murphy Cc: Christoph Hellwig , Joerg Roedel , Catalin Marinas , Will Deacon , Tom Lendacky , iommu@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org List-Id: iommu@lists.linux-foundation.org On Wed, Apr 10, 2019 at 08:11:57AM +0200, Christoph Hellwig wrote: > On Tue, Apr 09, 2019 at 06:59:32PM +0100, Robin Murphy wrote: > > On 27/03/2019 08:04, Christoph Hellwig wrote: > >> This keeps the code together and will simplify compiling the code > >> out on architectures that are always dma coherent. > > > > And this is where things take a turn in the direction I just can't get on > > with - I'm looking at the final result and the twisty maze of little > > disjoint helpers all overlapping each other in functionality is really > > difficult to follow. And I would *much* rather have things rely on > > compile-time constant optimisation than spend the future having to fix the > > #ifdefed parts for arm64 whenever x86-centric changes fail to test them. > > Can you draft up a patch on top of my series to show me what you > want? I can take care of finishing it up and moving the changes > into the right patches in the series. Any chance to make some progress on this? Or at least a better description of what you want? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76E25C10F12 for ; Wed, 17 Apr 2019 06:34:33 +0000 (UTC) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4E5752073F for ; Wed, 17 Apr 2019 06:34:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4E5752073F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id 223AFCAB; Wed, 17 Apr 2019 06:34:16 +0000 (UTC) Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 2FE39CAA for ; Wed, 17 Apr 2019 06:34:14 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from newverein.lst.de (verein.lst.de [213.95.11.211]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 9C9E2F4 for ; Wed, 17 Apr 2019 06:34:13 +0000 (UTC) Received: by newverein.lst.de (Postfix, from userid 2407) id B66FE68AFE; Wed, 17 Apr 2019 08:33:58 +0200 (CEST) Date: Wed, 17 Apr 2019 08:33:58 +0200 From: Christoph Hellwig To: Robin Murphy Subject: Re: [PATCH 12/21] dma-iommu: factor atomic pool allocations into helpers Message-ID: <20190417063358.GA24139@lst.de> References: <20190327080448.5500-1-hch@lst.de> <20190327080448.5500-13-hch@lst.de> <20190410061157.GA5278@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190410061157.GA5278@lst.de> User-Agent: Mutt/1.5.17 (2007-11-01) Cc: Tom Lendacky , Catalin Marinas , Will Deacon , linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, Christoph Hellwig , linux-arm-kernel@lists.infradead.org X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Sender: iommu-bounces@lists.linux-foundation.org Errors-To: iommu-bounces@lists.linux-foundation.org Message-ID: <20190417063358.4PF5C_EV2MrwQL832LVKGKKBSkj06qBOzDLDGzkgF4g@z> On Wed, Apr 10, 2019 at 08:11:57AM +0200, Christoph Hellwig wrote: > On Tue, Apr 09, 2019 at 06:59:32PM +0100, Robin Murphy wrote: > > On 27/03/2019 08:04, Christoph Hellwig wrote: > >> This keeps the code together and will simplify compiling the code > >> out on architectures that are always dma coherent. > > > > And this is where things take a turn in the direction I just can't get on > > with - I'm looking at the final result and the twisty maze of little > > disjoint helpers all overlapping each other in functionality is really > > difficult to follow. And I would *much* rather have things rely on > > compile-time constant optimisation than spend the future having to fix the > > #ifdefed parts for arm64 whenever x86-centric changes fail to test them. > > Can you draft up a patch on top of my series to show me what you > want? I can take care of finishing it up and moving the changes > into the right patches in the series. Any chance to make some progress on this? Or at least a better description of what you want? _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu