Re: [patch V2 14/29] dm bufio: Simplify stack trace retrieval

Thomas Gleixner
2019-04-18T11:54:37Z

On Thu, 18 Apr 2019, Alexander Potapenko wrote:
> On Thu, Apr 18, 2019 at 11:06 AM Thomas Gleixner <tglx@linutronix.de> wrote:
> > - save_stack_trace(&b->stack_trace);
> > + b->stack_len = stack_trace_save(b->stack_entries, MAX_STACK, 2);
> As noted in one of similar patches before, can we have an inline
> comment to indicate what does this "2" stand for?

Come on. We have gazillion of functions which take numerical constant
arguments. Should we add comments to all of them?

Thanks,

tglx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org