[patch V2 00/29] stacktrace: Consolidate stack trace usage

Thomas Gleixner
2019-04-18T08:41:19Z

This is an update to V1:

https://lkml.kernel.org/r/20190410102754.387743324-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org

Struct stack_trace is a sinkhole for input and output parameters which is
largely pointless for most usage sites. In fact if embedded into other data
structures it creates indirections and extra storage overhead for no
benefit.

Looking at all usage sites makes it clear that they just require an
interface which is based on a storage array. That array is either on stack,
global or embedded into some other data structure.

Some of the stack depot usage sites are outright wrong, but fortunately the
wrongness just causes more stack being used for nothing and does not have
functional impact.

Fix this up by:

1) Providing plain storage array based interfaces for stacktrace and
stackdepot.

2) Cleaning up the mess at the callsites including some related
cleanups.

3) Removing the struct stack_trace based interfaces

This is not yet changing the struct stack_trace interfaces at the
architecture level, but it removes the exposure to the usage sites.

The last two patches are extending the cleanup to the architecture level by
replacing the various save_stack_trace.* architecture interfaces with a
more unified arch_stack_walk() interface. x86 is converted, but I have
worked through all architectures already and it removes lots of duplicated
code and allows consolidation across the board. The rest of the
architecture patches are not included in this posting as I want to get
feedback on the approach itself. The diffstat of cleaning up the remaining
architectures is currently on top of the current lot is:

47 files changed, 402 insertions(+), 1196 deletions(-)

Once this has settled, the core interfaces can be improved by adding
features, which allow to get rid of the imprecise 'skip number of entries'
approach which tries to remove the stack tracer and the callsites themself
from the trace. That's error prone due to inlining and other issues. Having
e.g. a _RET_IP_ based filter allows to do that far more reliable.

The series is based on:

git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git core/stacktrace

which contains the removal of the inconsistent and pointless ULONG_MAX
termination of stacktraces.

It's also available from git:

git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git WIP.core/stacktrace

up to: 131038eb3e2f ("x86/stacktrace: Use common infrastructure")

Changes vs. V1:

- Applied the ULONG_MAX termination cleanup in tip

- Addressed the review comments

- Fixed up the last users of struct stack_trace outside the stacktrace
core and architecture code (livepatch, tracing)

- Added the new arch_stack_walk() model and converted x86 to it

Thanks,

tglx

---
arch/x86/Kconfig | 1
arch/x86/kernel/stacktrace.c | 116 +--------
drivers/gpu/drm/drm_mm.c | 22 -
drivers/gpu/drm/i915/i915_vma.c | 11
drivers/gpu/drm/i915/intel_runtime_pm.c | 21 -
drivers/md/dm-bufio.c | 15 -
drivers/md/persistent-data/dm-block-manager.c | 19 -
fs/btrfs/ref-verify.c | 15 -
fs/proc/base.c | 14 -
include/linux/ftrace.h | 18 -
include/linux/lockdep.h | 9
include/linux/stackdepot.h | 8
include/linux/stacktrace.h | 80 +++++-
kernel/backtracetest.c | 11
kernel/dma/debug.c | 13 -
kernel/latencytop.c | 17 -
kernel/livepatch/transition.c | 22 -
kernel/locking/lockdep.c | 81 ++----
kernel/stacktrace.c | 323 ++++++++++++++++++++++++--
kernel/trace/trace.c | 105 +++-----
kernel/trace/trace.h | 8
kernel/trace/trace_events_hist.c | 12
kernel/trace/trace_stack.c | 76 ++----
lib/Kconfig | 4
lib/fault-inject.c | 12
lib/stackdepot.c | 50 ++--
mm/kasan/common.c | 30 --
mm/kasan/report.c | 7
mm/kmemleak.c | 24 -
mm/page_owner.c | 79 ++----
mm/slub.c | 12
31 files changed, 664 insertions(+), 571 deletions(-)