From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Gleixner Subject: [patch V2 20/29] tracing: Simplify stacktrace retrieval in histograms Date: Thu, 18 Apr 2019 10:41:39 +0200 Message-ID: <20190418084254.910579307@linutronix.de> References: <20190418084119.056416939@linutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: LKML Cc: Mike Snitzer , David Airlie , Catalin Marinas , dri-devel@lists.freedesktop.org, linux-mm@kvack.org, dm-devel@redhat.com, Alexander Potapenko , Christoph Lameter , Christoph Hellwig , Alasdair Kergon , Marek Szyprowski , linux-arch@vger.kernel.org, x86@kernel.org, kasan-dev@googlegroups.com, Johannes Thumshirn , Andrey Ryabinin , Alexey Dobriyan , intel-gfx@lists.freedesktop.org, David Rientjes , Akinobu Mita , Steven Rostedt , Josef Bacik , Mike Rapoport , Andy Lutomirski , Josh Poimboeuf , David Sterba List-Id: iommu@lists.linux-foundation.org VGhlIGluZGlyZWN0aW9uIHRocm91Z2ggc3RydWN0IHN0YWNrX3RyYWNlIGlzIG5vdCBuZWNlc3Nh cnkgYXQgYWxsLiBVc2UgdGhlCnN0b3JhZ2UgYXJyYXkgYmFzZWQgaW50ZXJmYWNlLgoKU2lnbmVk LW9mZi1ieTogVGhvbWFzIEdsZWl4bmVyIDx0Z2x4QGxpbnV0cm9uaXguZGU+CkNjOiBTdGV2ZW4g Um9zdGVkdCA8cm9zdGVkdEBnb29kbWlzLm9yZz4KLS0tCiBrZXJuZWwvdHJhY2UvdHJhY2VfZXZl bnRzX2hpc3QuYyB8ICAgMTIgKysrLS0tLS0tLS0tCiAxIGZpbGUgY2hhbmdlZCwgMyBpbnNlcnRp b25zKCspLCA5IGRlbGV0aW9ucygtKQoKLS0tIGEva2VybmVsL3RyYWNlL3RyYWNlX2V2ZW50c19o aXN0LmMKKysrIGIva2VybmVsL3RyYWNlL3RyYWNlX2V2ZW50c19oaXN0LmMKQEAgLTUxODYsNyAr NTE4Niw2IEBAIHN0YXRpYyB2b2lkIGV2ZW50X2hpc3RfdHJpZ2dlcihzdHJ1Y3QgZXYKIAl1NjQg dmFyX3JlZl92YWxzW1RSQUNJTkdfTUFQX1ZBUlNfTUFYXTsKIAljaGFyIGNvbXBvdW5kX2tleVtI SVNUX0tFWV9TSVpFX01BWF07CiAJc3RydWN0IHRyYWNpbmdfbWFwX2VsdCAqZWx0ID0gTlVMTDsK LQlzdHJ1Y3Qgc3RhY2tfdHJhY2Ugc3RhY2t0cmFjZTsKIAlzdHJ1Y3QgaGlzdF9maWVsZCAqa2V5 X2ZpZWxkOwogCXU2NCBmaWVsZF9jb250ZW50czsKIAl2b2lkICprZXkgPSBOVUxMOwpAQCAtNTE5 OCwxNCArNTE5Nyw5IEBAIHN0YXRpYyB2b2lkIGV2ZW50X2hpc3RfdHJpZ2dlcihzdHJ1Y3QgZXYK IAkJa2V5X2ZpZWxkID0gaGlzdF9kYXRhLT5maWVsZHNbaV07CiAKIAkJaWYgKGtleV9maWVsZC0+ ZmxhZ3MgJiBISVNUX0ZJRUxEX0ZMX1NUQUNLVFJBQ0UpIHsKLQkJCXN0YWNrdHJhY2UubWF4X2Vu dHJpZXMgPSBISVNUX1NUQUNLVFJBQ0VfREVQVEg7Ci0JCQlzdGFja3RyYWNlLmVudHJpZXMgPSBl bnRyaWVzOwotCQkJc3RhY2t0cmFjZS5ucl9lbnRyaWVzID0gMDsKLQkJCXN0YWNrdHJhY2Uuc2tp cCA9IEhJU1RfU1RBQ0tUUkFDRV9TS0lQOwotCi0JCQltZW1zZXQoc3RhY2t0cmFjZS5lbnRyaWVz LCAwLCBISVNUX1NUQUNLVFJBQ0VfU0laRSk7Ci0JCQlzYXZlX3N0YWNrX3RyYWNlKCZzdGFja3Ry YWNlKTsKLQorCQkJbWVtc2V0KGVudHJpZXMsIDAsIEhJU1RfU1RBQ0tUUkFDRV9TSVpFKTsKKwkJ CXN0YWNrX3RyYWNlX3NhdmUoZW50cmllcywgSElTVF9TVEFDS1RSQUNFX0RFUFRILAorCQkJCQkg SElTVF9TVEFDS1RSQUNFX1NLSVApOwogCQkJa2V5ID0gZW50cmllczsKIAkJfSBlbHNlIHsKIAkJ CWZpZWxkX2NvbnRlbnRzID0ga2V5X2ZpZWxkLT5mbihrZXlfZmllbGQsIGVsdCwgcmJlLCByZWMp OwoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVs LWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczov L2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeA== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25FA2C10F0E for ; Thu, 18 Apr 2019 09:33:44 +0000 (UTC) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 00C8B214DA for ; Thu, 18 Apr 2019 09:33:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 00C8B214DA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linutronix.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id DAC121486; Thu, 18 Apr 2019 09:33:43 +0000 (UTC) Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id AAAEF115D for ; Thu, 18 Apr 2019 09:33:42 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from Galois.linutronix.de (Galois.linutronix.de [146.0.238.70]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 4C35F466 for ; Thu, 18 Apr 2019 09:33:42 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=nanos.tec.linutronix.de) by Galois.linutronix.de with esmtp (Exim 4.80) (envelope-from ) id 1hH30D-0001tl-Se; Thu, 18 Apr 2019 11:06:42 +0200 Message-Id: <20190418084254.910579307@linutronix.de> User-Agent: quilt/0.65 Date: Thu, 18 Apr 2019 10:41:39 +0200 From: Thomas Gleixner To: LKML Subject: [patch V2 20/29] tracing: Simplify stacktrace retrieval in histograms References: <20190418084119.056416939@linutronix.de> MIME-Version: 1.0 Cc: Mike Snitzer , David Airlie , Catalin Marinas , Joonas Lahtinen , dri-devel@lists.freedesktop.org, linux-mm@kvack.org, dm-devel@redhat.com, Alexander Potapenko , Christoph Lameter , Christoph Hellwig , Alasdair Kergon , linux-arch@vger.kernel.org, x86@kernel.org, kasan-dev@googlegroups.com, Johannes Thumshirn , Andrey Ryabinin , Alexey Dobriyan , intel-gfx@lists.freedesktop.org, David Rientjes , Maarten Lankhorst , Akinobu Mita , Steven Rostedt , Josef Bacik , Rodrigo Vivi , Mike Rapoport , Jani Nikula , Andy Lutomirski , Josh Poimboeuf , David Sterba , Dmitry Vyukov , Chris Mason , Pekka Enberg , iommu@lists.linux-foundation.org, Daniel Vetter , Andrew Morton , Robin Murphy , linux-btrfs@vger.kernel.org X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Sender: iommu-bounces@lists.linux-foundation.org Errors-To: iommu-bounces@lists.linux-foundation.org Message-ID: <20190418084139.Hh54-_nkSXcD-S_Tsx1fR1XCI7ksLmrOZxChQlgpLAw@z> The indirection through struct stack_trace is not necessary at all. Use the storage array based interface. Signed-off-by: Thomas Gleixner Cc: Steven Rostedt --- kernel/trace/trace_events_hist.c | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) --- a/kernel/trace/trace_events_hist.c +++ b/kernel/trace/trace_events_hist.c @@ -5186,7 +5186,6 @@ static void event_hist_trigger(struct ev u64 var_ref_vals[TRACING_MAP_VARS_MAX]; char compound_key[HIST_KEY_SIZE_MAX]; struct tracing_map_elt *elt = NULL; - struct stack_trace stacktrace; struct hist_field *key_field; u64 field_contents; void *key = NULL; @@ -5198,14 +5197,9 @@ static void event_hist_trigger(struct ev key_field = hist_data->fields[i]; if (key_field->flags & HIST_FIELD_FL_STACKTRACE) { - stacktrace.max_entries = HIST_STACKTRACE_DEPTH; - stacktrace.entries = entries; - stacktrace.nr_entries = 0; - stacktrace.skip = HIST_STACKTRACE_SKIP; - - memset(stacktrace.entries, 0, HIST_STACKTRACE_SIZE); - save_stack_trace(&stacktrace); - + memset(entries, 0, HIST_STACKTRACE_SIZE); + stack_trace_save(entries, HIST_STACKTRACE_DEPTH, + HIST_STACKTRACE_SKIP); key = entries; } else { field_contents = key_field->fn(key_field, elt, rbe, rec); _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu