From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jacob Pan Subject: Re: [PATCH v2 06/19] drivers core: Add I/O ASID allocator Date: Thu, 25 Apr 2019 11:19:12 -0700 Message-ID: <20190425111912.0e15eb7d@jacob-builder> References: <1556062279-64135-1-git-send-email-jacob.jun.pan@linux.intel.com> <1556062279-64135-7-git-send-email-jacob.jun.pan@linux.intel.com> <20190424061903.GB30717@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8BIT Return-path: In-Reply-To: <20190424061903.GB30717@infradead.org> Sender: linux-kernel-owner@vger.kernel.org To: Christoph Hellwig Cc: iommu@lists.linux-foundation.org, LKML , Joerg Roedel , David Woodhouse , Eric Auger , Alex Williamson , Jean-Philippe Brucker , Yi Liu , "Tian, Kevin" , Raj Ashok , Lu Baolu , Andriy Shevchenko , jacob.jun.pan@linux.intel.com List-Id: iommu@lists.linux-foundation.org Hi Christoph, On Tue, 23 Apr 2019 23:19:03 -0700 Christoph Hellwig wrote: > On Tue, Apr 23, 2019 at 04:31:06PM -0700, Jacob Pan wrote: > > The allocator doesn't really belong in drivers/iommu because some > > drivers would like to allocate PASIDs for devices that aren't > > managed by an IOMMU, using the same ID space as IOMMU. It doesn't > > really belong in drivers/pci either since platform device also > > support PASID. Add the allocator in drivers/base. > > I'd still add it to drivers/iommu, just selectable separately from the > core iommu code.. Perhaps I misunderstood. If a driver wants to use IOASIDs w/o iommu subsystem even turned on, how could selecting from the core iommu code help? Could you elaborate on "selectable"? >>From VT-d's perspective, PASIDs are only used with IOMMU on. Jean knows other use cases. Jacob From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A51CC43219 for ; Thu, 25 Apr 2019 18:17:09 +0000 (UTC) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8B7EB20685 for ; Thu, 25 Apr 2019 18:17:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8B7EB20685 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id A43D9219E; Thu, 25 Apr 2019 18:17:08 +0000 (UTC) Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 39C452198 for ; Thu, 25 Apr 2019 18:16:31 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id C3CB8860 for ; Thu, 25 Apr 2019 18:16:30 +0000 (UTC) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Apr 2019 11:16:30 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,394,1549958400"; d="scan'208";a="340780163" Received: from jacob-builder.jf.intel.com (HELO jacob-builder) ([10.7.199.155]) by fmsmga005.fm.intel.com with ESMTP; 25 Apr 2019 11:16:29 -0700 Date: Thu, 25 Apr 2019 11:19:12 -0700 From: Jacob Pan To: Christoph Hellwig Subject: Re: [PATCH v2 06/19] drivers core: Add I/O ASID allocator Message-ID: <20190425111912.0e15eb7d@jacob-builder> In-Reply-To: <20190424061903.GB30717@infradead.org> References: <1556062279-64135-1-git-send-email-jacob.jun.pan@linux.intel.com> <1556062279-64135-7-git-send-email-jacob.jun.pan@linux.intel.com> <20190424061903.GB30717@infradead.org> Organization: OTC X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Cc: "Tian, Kevin" , Raj Ashok , Jean-Philippe Brucker , iommu@lists.linux-foundation.org, LKML , Alex Williamson , Andriy Shevchenko , David Woodhouse X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Sender: iommu-bounces@lists.linux-foundation.org Errors-To: iommu-bounces@lists.linux-foundation.org Message-ID: <20190425181912.ItNLBV73oOR7c6brVMfTlyI3-JhFUPvtNA8ofxUxq_k@z> Hi Christoph, On Tue, 23 Apr 2019 23:19:03 -0700 Christoph Hellwig wrote: > On Tue, Apr 23, 2019 at 04:31:06PM -0700, Jacob Pan wrote: > > The allocator doesn't really belong in drivers/iommu because some > > drivers would like to allocate PASIDs for devices that aren't > > managed by an IOMMU, using the same ID space as IOMMU. It doesn't > > really belong in drivers/pci either since platform device also > > support PASID. Add the allocator in drivers/base. > > I'd still add it to drivers/iommu, just selectable separately from the > core iommu code.. Perhaps I misunderstood. If a driver wants to use IOASIDs w/o iommu subsystem even turned on, how could selecting from the core iommu code help? Could you elaborate on "selectable"? >From VT-d's perspective, PASIDs are only used with IOMMU on. Jean knows other use cases. Jacob _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu