From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jacob Pan Subject: Re: [PATCH v2 09/19] iommu/vt-d: Enlightened PASID allocation Date: Fri, 26 Apr 2019 08:05:45 -0700 Message-ID: <20190426080545.485a4124@jacob-builder> References: <1556062279-64135-1-git-send-email-jacob.jun.pan@linux.intel.com> <1556062279-64135-10-git-send-email-jacob.jun.pan@linux.intel.com> <143adac1-d58b-dde6-593b-74ea71da73c8@redhat.com> <20190425164017.6aed942e@jacob-builder> <8e063ce8-e5bb-5de8-f243-852c7a692c98@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <8e063ce8-e5bb-5de8-f243-852c7a692c98@redhat.com> Sender: linux-kernel-owner@vger.kernel.org To: Auger Eric Cc: iommu@lists.linux-foundation.org, LKML , Joerg Roedel , David Woodhouse , Alex Williamson , Jean-Philippe Brucker , Yi Liu , "Tian, Kevin" , Raj Ashok , Christoph Hellwig , Lu Baolu , Andriy Shevchenko , jacob.jun.pan@linux.intel.com List-Id: iommu@lists.linux-foundation.org On Fri, 26 Apr 2019 09:24:29 +0200 Auger Eric wrote: > > Agreed > >>> +#define VCMD_VRSP_RESULE(e) (((e) >> 8) & > >>> 0xfffff) > >> nit: s/RESULE/RSLT? > > yes. Also the mask bits should be 8 to 63 > > s/0xfffff/GENMASK_ULL(63, 8))/ > Well the macro definition looks correct as 63:28 is RsvdZ you are right, I misread the spec. Thanks, Jacob From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 506EFC43219 for ; Fri, 26 Apr 2019 15:06:05 +0000 (UTC) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2AD09206E0 for ; Fri, 26 Apr 2019 15:06:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2AD09206E0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id E325F27F3; Fri, 26 Apr 2019 15:06:04 +0000 (UTC) Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 6E81127E6 for ; Fri, 26 Apr 2019 15:03:03 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 643BA74A for ; Fri, 26 Apr 2019 15:03:02 +0000 (UTC) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Apr 2019 08:03:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,397,1549958400"; d="scan'208";a="134637354" Received: from jacob-builder.jf.intel.com (HELO jacob-builder) ([10.7.199.155]) by orsmga007.jf.intel.com with ESMTP; 26 Apr 2019 08:03:01 -0700 Date: Fri, 26 Apr 2019 08:05:45 -0700 From: Jacob Pan To: Auger Eric Subject: Re: [PATCH v2 09/19] iommu/vt-d: Enlightened PASID allocation Message-ID: <20190426080545.485a4124@jacob-builder> In-Reply-To: <8e063ce8-e5bb-5de8-f243-852c7a692c98@redhat.com> References: <1556062279-64135-1-git-send-email-jacob.jun.pan@linux.intel.com> <1556062279-64135-10-git-send-email-jacob.jun.pan@linux.intel.com> <143adac1-d58b-dde6-593b-74ea71da73c8@redhat.com> <20190425164017.6aed942e@jacob-builder> <8e063ce8-e5bb-5de8-f243-852c7a692c98@redhat.com> Organization: OTC X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Cc: "Tian, Kevin" , Raj Ashok , Jean-Philippe Brucker , iommu@lists.linux-foundation.org, LKML , Alex Williamson , Andriy Shevchenko , David Woodhouse X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Sender: iommu-bounces@lists.linux-foundation.org Errors-To: iommu-bounces@lists.linux-foundation.org Message-ID: <20190426150545.TmZbp9-eYyuQ6llW42H7ArMniPqYxn4ZipMl3vKoquc@z> On Fri, 26 Apr 2019 09:24:29 +0200 Auger Eric wrote: > > Agreed > >>> +#define VCMD_VRSP_RESULE(e) (((e) >> 8) & > >>> 0xfffff) > >> nit: s/RESULE/RSLT? > > yes. Also the mask bits should be 8 to 63 > > s/0xfffff/GENMASK_ULL(63, 8))/ > Well the macro definition looks correct as 63:28 is RsvdZ you are right, I misread the spec. Thanks, Jacob _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu