From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joerg Roedel Subject: Re: [PATCH v2 6/9] iommu/amd: use helper pci_dev_id Date: Fri, 26 Apr 2019 15:47:10 +0200 Message-ID: <20190426134710.GD24576@8bytes.org> References: <2e1f9a57-6d08-d017-24da-3e6b97fa2449@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Heiner Kallweit Cc: Benjamin Herrenschmidt , Michael Ellerman , Oded Gabbay , Alex Deucher , Christian =?iso-8859-1?Q?K=F6nig?= , "David (ChunMing) Zhou" , David Airlie , Daniel Vetter , David Woodhouse , Realtek linux nic maintainers , "David S. Miller" , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , Maxime Coquelin , Bjorn Helgaas , Benson Leung , Enric Balletbo i Serra List-Id: iommu@lists.linux-foundation.org On Wed, Apr 24, 2019 at 09:15:25PM +0200, Heiner Kallweit wrote: > Use new helper pci_dev_id() to simplify the code. > > Signed-off-by: Heiner Kallweit Reviewed-by: Joerg Roedel > --- > drivers/iommu/amd_iommu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iommu/amd_iommu.c b/drivers/iommu/amd_iommu.c > index f467cc4b4..5cb201422 100644 > --- a/drivers/iommu/amd_iommu.c > +++ b/drivers/iommu/amd_iommu.c > @@ -165,7 +165,7 @@ static inline u16 get_pci_device_id(struct device *dev) > { > struct pci_dev *pdev = to_pci_dev(dev); > > - return PCI_DEVID(pdev->bus->number, pdev->devfn); > + return pci_dev_id(pdev); > } > > static inline int get_acpihid_device_id(struct device *dev, > -- > 2.21.0 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33F2DC43218 for ; Fri, 26 Apr 2019 13:49:22 +0000 (UTC) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0B5C1206E0 for ; Fri, 26 Apr 2019 13:49:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0B5C1206E0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=8bytes.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id 943F027E0; Fri, 26 Apr 2019 13:49:18 +0000 (UTC) Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id D326527D5 for ; Fri, 26 Apr 2019 13:47:14 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from theia.8bytes.org (8bytes.org [81.169.241.247]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 6669274A for ; Fri, 26 Apr 2019 13:47:14 +0000 (UTC) Received: by theia.8bytes.org (Postfix, from userid 1000) id 11282447; Fri, 26 Apr 2019 15:47:11 +0200 (CEST) Date: Fri, 26 Apr 2019 15:47:10 +0200 From: Joerg Roedel To: Heiner Kallweit Subject: Re: [PATCH v2 6/9] iommu/amd: use helper pci_dev_id Message-ID: <20190426134710.GD24576@8bytes.org> References: <2e1f9a57-6d08-d017-24da-3e6b97fa2449@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Cc: David Airlie , Benjamin Herrenschmidt , "open list:AMD KFD" , Paul Mackerras , "moderated list:ARM/STM32 ARCHITECTURE" , "David \(ChunMing\) Zhou" , Michael Ellerman , "open list:RADEON and AMDGPU DRM DRIVERS" , Jose Abreu , "open list:PCI SUBSYSTEM" , Realtek linux nic maintainers , Alexandre Torgue , Stephen Rothwell , Alex Deucher , Bjorn Helgaas , Giuseppe Cavallaro , Benson Leung , "moderated list:ARM/STM32 ARCHITECTURE" , Maxime Coquelin , "open list:8169 10/100/1000 GIGABIT ETHERNET DRIVER" , open list , Christian =?iso-8859-1?Q?K=F6nig?= , "open list:AMD IOMMU \(AMD-VI\)" , Daniel Vetter , Enric Balletbo i Serra , David Woodhouse , "David S. Miller" X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Sender: iommu-bounces@lists.linux-foundation.org Errors-To: iommu-bounces@lists.linux-foundation.org Message-ID: <20190426134710.9HxKT61YHN7lxwCISmq9AgBWTBO9CnKVtRipcbbnd-4@z> On Wed, Apr 24, 2019 at 09:15:25PM +0200, Heiner Kallweit wrote: > Use new helper pci_dev_id() to simplify the code. > > Signed-off-by: Heiner Kallweit Reviewed-by: Joerg Roedel > --- > drivers/iommu/amd_iommu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iommu/amd_iommu.c b/drivers/iommu/amd_iommu.c > index f467cc4b4..5cb201422 100644 > --- a/drivers/iommu/amd_iommu.c > +++ b/drivers/iommu/amd_iommu.c > @@ -165,7 +165,7 @@ static inline u16 get_pci_device_id(struct device *dev) > { > struct pci_dev *pdev = to_pci_dev(dev); > > - return PCI_DEVID(pdev->bus->number, pdev->devfn); > + return pci_dev_id(pdev); > } > > static inline int get_acpihid_device_id(struct device *dev, > -- > 2.21.0 > _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu