From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jacob Pan Subject: Re: [PATCH v2 06/19] drivers core: Add I/O ASID allocator Date: Tue, 30 Apr 2019 13:24:05 -0700 Message-ID: <20190430132405.62902350@jacob-builder> References: <1556062279-64135-1-git-send-email-jacob.jun.pan@linux.intel.com> <1556062279-64135-7-git-send-email-jacob.jun.pan@linux.intel.com> <4550408f-39ff-7bf9-0072-a0898c6c2f60@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Jean-Philippe Brucker Cc: Auger Eric , iommu@lists.linux-foundation.org, LKML , Joerg Roedel , David Woodhouse , Alex Williamson , "Tian, Kevin" , Raj Ashok , Andriy Shevchenko , jacob.jun.pan@linux.intel.com List-Id: iommu@lists.linux-foundation.org On Thu, 25 Apr 2019 11:41:05 +0100 Jean-Philippe Brucker wrote: > On 25/04/2019 11:17, Auger Eric wrote: > >> +/** > >> + * ioasid_alloc - Allocate an IOASID > >> + * @set: the IOASID set > >> + * @min: the minimum ID (inclusive) > >> + * @max: the maximum ID (exclusive) > >> + * @private: data private to the caller > >> + * > >> + * Allocate an ID between @min and @max (or %0 and %INT_MAX). > >> Return the > > I would remove "(or %0 and %INT_MAX)". > > Agreed, those where the default values of idr, but the xarray doesn't > define a default max value. By the way, I do think squashing patches 6 > and 7 would be better (keeping my SOB but you can change the author). > I will squash 6 and 7 in v3. I will just add my SOB but keep the author if that is OK. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94AD4C43219 for ; Tue, 30 Apr 2019 20:21:57 +0000 (UTC) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 69A1A20652 for ; Tue, 30 Apr 2019 20:21:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 69A1A20652 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id 41C191DC8; Tue, 30 Apr 2019 20:21:57 +0000 (UTC) Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 5A9951D99 for ; Tue, 30 Apr 2019 20:21:21 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id D712F608 for ; Tue, 30 Apr 2019 20:21:20 +0000 (UTC) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Apr 2019 13:21:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,414,1549958400"; d="scan'208";a="228167388" Received: from jacob-builder.jf.intel.com (HELO jacob-builder) ([10.7.199.155]) by orsmga001.jf.intel.com with ESMTP; 30 Apr 2019 13:21:19 -0700 Date: Tue, 30 Apr 2019 13:24:05 -0700 From: Jacob Pan To: Jean-Philippe Brucker Subject: Re: [PATCH v2 06/19] drivers core: Add I/O ASID allocator Message-ID: <20190430132405.62902350@jacob-builder> In-Reply-To: References: <1556062279-64135-1-git-send-email-jacob.jun.pan@linux.intel.com> <1556062279-64135-7-git-send-email-jacob.jun.pan@linux.intel.com> <4550408f-39ff-7bf9-0072-a0898c6c2f60@redhat.com> Organization: OTC X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Cc: "Tian, Kevin" , Raj Ashok , iommu@lists.linux-foundation.org, LKML , Alex Williamson , Andriy Shevchenko , David Woodhouse X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Sender: iommu-bounces@lists.linux-foundation.org Errors-To: iommu-bounces@lists.linux-foundation.org Message-ID: <20190430202405.j3qjxAO6qagXf04PD6MLcPiKzMw7qBhVDF2ZpNTE4KQ@z> On Thu, 25 Apr 2019 11:41:05 +0100 Jean-Philippe Brucker wrote: > On 25/04/2019 11:17, Auger Eric wrote: > >> +/** > >> + * ioasid_alloc - Allocate an IOASID > >> + * @set: the IOASID set > >> + * @min: the minimum ID (inclusive) > >> + * @max: the maximum ID (exclusive) > >> + * @private: data private to the caller > >> + * > >> + * Allocate an ID between @min and @max (or %0 and %INT_MAX). > >> Return the > > I would remove "(or %0 and %INT_MAX)". > > Agreed, those where the default values of idr, but the xarray doesn't > define a default max value. By the way, I do think squashing patches 6 > and 7 would be better (keeping my SOB but you can change the author). > I will squash 6 and 7 in v3. I will just add my SOB but keep the author if that is OK. _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu