From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9EFD2C004C9 for ; Tue, 7 May 2019 11:24:56 +0000 (UTC) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 60B422054F for ; Tue, 7 May 2019 11:24:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 60B422054F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id 96049131B; Tue, 7 May 2019 11:24:51 +0000 (UTC) Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 0AFD71312 for ; Tue, 7 May 2019 11:24:50 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from newverein.lst.de (verein.lst.de [213.95.11.211]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 7DAB1878 for ; Tue, 7 May 2019 06:36:38 +0000 (UTC) Received: by newverein.lst.de (Postfix, from userid 2407) id 0A8B967358; Tue, 7 May 2019 08:36:19 +0200 (CEST) Date: Tue, 7 May 2019 08:36:18 +0200 From: Christoph Hellwig To: Bartlomiej Zolnierkiewicz Subject: Re: [PATCH 2/7] au1100fb: fix DMA API abuse Message-ID: <20190507063618.GA28147@lst.de> References: <20190430110032.25301-1-hch@lst.de> <20190430110032.25301-3-hch@lst.de> <7a63eeae-4ec3-c82e-c497-8adc7bcb3cea@samsung.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <7a63eeae-4ec3-c82e-c497-8adc7bcb3cea@samsung.com> User-Agent: Mutt/1.5.17 (2007-11-01) Cc: Michal Simek , James Hogan , linux-mips@vger.kernel.org, Ralf Baechle , linux-kernel@vger.kernel.org, Paul Burton , iommu@lists.linux-foundation.org, linux-fbdev@vger.kernel.org, Ley Foon Tan , Christoph Hellwig X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: iommu-bounces@lists.linux-foundation.org Errors-To: iommu-bounces@lists.linux-foundation.org On Mon, May 06, 2019 at 03:49:35PM +0200, Bartlomiej Zolnierkiewicz wrote: > > On 04/30/2019 01:00 PM, Christoph Hellwig wrote: > > Virtual addresses return from dma(m)_alloc_coherent are opaque in what > > backs then, and drivers must not poke into them. Switch the driver > > to use the generic DMA API mmap helper to avoid these games. > > > > Signed-off-by: Christoph Hellwig > > Acked-by: Bartlomiej Zolnierkiewicz Given this actually fixes issues with the current driver, what do you think of taking it for 5.2 through your tree? Also au1200fb has basically the same issues, just without abusing the CAC_ADDR helper, I could send you a patch for that one as well. _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu