From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FF4CC04AB6 for ; Tue, 28 May 2019 06:25:16 +0000 (UTC) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 225AD208C3 for ; Tue, 28 May 2019 06:25:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="W83n7DMZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 225AD208C3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id D31021B5D; Tue, 28 May 2019 06:25:15 +0000 (UTC) Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 19F731B5C for ; Tue, 28 May 2019 06:24:20 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 732D4D0 for ; Tue, 28 May 2019 06:24:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Content-Transfer-Encoding: MIME-Version:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=5UTOpPtcHs8+TYR7e/ooqgilSmaZoeoYd8YGidb41CI=; b=W83n7DMZ/HGGBGO+mk/+j3B3p c8qY0eY5onPoT1cK3izLxsjR2tjr0tG/nubI6iqXj6OsnyJREEYxuAMptdP3w04TJERClZgrDhRPk aaH2293n3rxbv3XGVLHVO60LpGvgqN0hrPbSGWcIgrdta6TNMv1pYHbu1pmus2+3l6Cq5NMoELA3p 9/Rp250G0Mgxyu3+808hMdlSWxr49AIaxcRnzxLhgs+STFBEmJSnKMt95xe/mgVJ8DWq1sTJE2YDT PmE32egvDL0lB15S7L4n5aN+UbzGG7bML3j5Hm6OcQVvXnBFbuie1R4G95vIDP9INIuophTFPp+d1 JVQfLsjHQ==; Received: from 213-225-10-46.nat.highway.a1.net ([213.225.10.46] helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1hVVWz-0005Z7-QX; Tue, 28 May 2019 06:24:18 +0000 From: Christoph Hellwig To: linux@armlinux.org.uk Subject: [PATCH, resend] ARM: dma-mapping: don't use the atomic pool for DMA_ATTR_NO_KERNEL_MAPPING Date: Tue, 28 May 2019 08:24:14 +0200 Message-Id: <20190528062414.30287-1-hch@lst.de> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Cc: iommu@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: iommu-bounces@lists.linux-foundation.org Errors-To: iommu-bounces@lists.linux-foundation.org DMA allocations with the DMA_ATTR_NO_KERNEL_MAPPING do not return a kernel virtual address for use in driver, but are expected to be used entirely for userspace mappings and/or device private memory. Because of that we don't need to remap them as uncached, and thus don't need the atomic pool for non-blocking allocations. Note that using the DMA allocator with DMA_ATTR_NO_KERNEL_MAPPING from non-blocking context on a non-coherent device is actually broken without this patch as well, as we feed the address passes to dma_free_attrs directly to the genpool allocator, but for DMA_ATTR_NO_KERNEL_MAPPING allocations it actually contains the address of the first page pointer. Signed-off-by: Christoph Hellwig --- arch/arm/mm/dma-mapping.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/arch/arm/mm/dma-mapping.c b/arch/arm/mm/dma-mapping.c index 0a75058c11f3..30e891f54d36 100644 --- a/arch/arm/mm/dma-mapping.c +++ b/arch/arm/mm/dma-mapping.c @@ -724,6 +724,7 @@ static void *__dma_alloc(struct device *dev, size_t size, dma_addr_t *handle, gfp_t gfp, pgprot_t prot, bool is_coherent, unsigned long attrs, const void *caller) { + bool want_vaddr = !(attrs & DMA_ATTR_NO_KERNEL_MAPPING); u64 mask = get_coherent_dma_mask(dev); struct page *page = NULL; void *addr; @@ -735,7 +736,7 @@ static void *__dma_alloc(struct device *dev, size_t size, dma_addr_t *handle, .gfp = gfp, .prot = prot, .caller = caller, - .want_vaddr = ((attrs & DMA_ATTR_NO_KERNEL_MAPPING) == 0), + .want_vaddr = want_vaddr, .coherent_flag = is_coherent ? COHERENT : NORMAL, }; @@ -773,14 +774,14 @@ static void *__dma_alloc(struct device *dev, size_t size, dma_addr_t *handle, allowblock = gfpflags_allow_blocking(gfp); cma = allowblock ? dev_get_cma_area(dev) : false; - if (cma) + if (!allowblock && !is_coherent && want_vaddr) + buf->allocator = &pool_allocator; + else if (cma) buf->allocator = &cma_allocator; else if (is_coherent) buf->allocator = &simple_allocator; - else if (allowblock) - buf->allocator = &remap_allocator; else - buf->allocator = &pool_allocator; + buf->allocator = &remap_allocator; addr = buf->allocator->alloc(&args, &page); -- 2.20.1 _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu