From: Christoph Hellwig <hch@infradead.org>
To: Eric Auger <eric.auger@redhat.com>
Cc: alex.williamson@redhat.com, jean-philippe.brucker@arm.com,
dwmw2@infradead.org, linux-kernel@vger.kernel.org,
iommu@lists.linux-foundation.org, robin.murphy@arm.com,
eric.auger.pro@gmail.com
Subject: Re: [PATCH v5 1/7] iommu: Fix a leak in iommu_insert_resv_region
Date: Tue, 28 May 2019 23:17:56 -0700 [thread overview]
Message-ID: <20190529061756.GB26055@infradead.org> (raw)
In-Reply-To: <20190528115025.17194-2-eric.auger@redhat.com>
> } else if ((start >= a) && (end <= b)) {
> if (new->type == type)
> - goto done;
> + return 0;
> else
> pos = pos->next;
Please remove the pointless else after the return statement.
> } else {
> if (new->type == type) {
> phys_addr_t new_start = min(a, start);
> phys_addr_t new_end = max(b, end);
> + int ret;
>
> list_del(&entry->list);
> entry->start = new_start;
> entry->length = new_end - new_start + 1;
> - iommu_insert_resv_region(entry, regions);
> + ret = iommu_insert_resv_region(entry, regions);
> + kfree(entry);
> + return ret;
> } else {
> pos = pos->next;
> }
Same here.
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2019-05-29 6:21 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-28 11:50 [PATCH v5 0/7] RMRR related fixes and enhancements Eric Auger
2019-05-28 11:50 ` [PATCH v5 1/7] iommu: Fix a leak in iommu_insert_resv_region Eric Auger
2019-05-29 6:17 ` Christoph Hellwig [this message]
2019-05-29 15:38 ` Auger Eric
2019-05-28 11:50 ` [PATCH v5 2/7] iommu/vt-d: Duplicate iommu_resv_region objects per device list Eric Auger
2019-05-29 2:04 ` Lu Baolu
2019-05-29 15:40 ` Auger Eric
2019-05-28 11:50 ` [PATCH v5 3/7] iommu/vt-d: Introduce is_downstream_to_pci_bridge helper Eric Auger
2019-05-29 2:11 ` Lu Baolu
2019-05-29 6:21 ` Christoph Hellwig
2019-05-29 15:43 ` Auger Eric
2019-05-28 11:50 ` [PATCH v5 4/7] iommu/vt-d: Handle RMRR with PCI bridge device scopes Eric Auger
2019-05-29 2:12 ` Lu Baolu
2019-05-28 11:50 ` [PATCH v5 5/7] iommu/vt-d: Handle PCI bridge RMRR device scopes in intel_iommu_get_resv_regions Eric Auger
2019-05-29 2:13 ` Lu Baolu
2019-05-28 11:50 ` [PATCH v5 6/7] iommu: Introduce IOMMU_RESV_DIRECT_RELAXABLE reserved memory regions Eric Auger
2019-05-28 11:50 ` [PATCH v5 7/7] iommu/vt-d: Differentiate relaxable and non relaxable RMRRs Eric Auger
2019-05-29 2:34 ` Lu Baolu
2019-05-29 15:43 ` Auger Eric
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190529061756.GB26055@infradead.org \
--to=hch@infradead.org \
--cc=alex.williamson@redhat.com \
--cc=dwmw2@infradead.org \
--cc=eric.auger.pro@gmail.com \
--cc=eric.auger@redhat.com \
--cc=iommu@lists.linux-foundation.org \
--cc=jean-philippe.brucker@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox