Re: [PATCH v2 0/4] iommu: Add device fault reporting API

Jean-Philippe Brucker
2019-06-12T11:57:34Z

On 12/06/2019 09:19, Joerg Roedel wrote:
> On Mon, Jun 03, 2019 at 03:57:45PM +0100, Jean-Philippe Brucker wrote:
>> Jacob Pan (3):
>> driver core: Add per device iommu param
>> iommu: Introduce device fault data
>> iommu: Introduce device fault report API
>>
>> Jean-Philippe Brucker (1):
>> iommu: Add recoverable fault reporting
>>
>> drivers/iommu/iommu.c | 236 ++++++++++++++++++++++++++++++++++++-
>> include/linux/device.h | 3 +
>> include/linux/iommu.h | 87 ++++++++++++++
>> include/uapi/linux/iommu.h | 153 ++++++++++++++++++++++++
>> 4 files changed, 476 insertions(+), 3 deletions(-)
>> create mode 100644 include/uapi/linux/iommu.h
>
> Applied, thanks.

Thanks! As discussed I think we need to add padding into the iommu_fault
structure before this reaches mainline, to make the UAPI easier to
extend in the future. It's already possible to extend but requires
introducing a new ABI version number and support two structures. Adding
some padding would only require introducing new flags. If there is no
objection I'll send a one-line patch bumping the structure size to 64
bytes (currently 48)

Thanks,
Jean