From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D239C31E4B for ; Fri, 14 Jun 2019 15:09:16 +0000 (UTC) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3A81B21537 for ; Fri, 14 Jun 2019 15:09:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3A81B21537 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id E4B9413C2; Fri, 14 Jun 2019 15:09:02 +0000 (UTC) Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 03CC013B2 for ; Fri, 14 Jun 2019 15:09:01 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from newverein.lst.de (verein.lst.de [213.95.11.211]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id AF1ADE5 for ; Fri, 14 Jun 2019 15:08:59 +0000 (UTC) Received: by newverein.lst.de (Postfix, from userid 2407) id EDC7268B05; Fri, 14 Jun 2019 17:08:27 +0200 (CEST) Date: Fri, 14 Jun 2019 17:08:27 +0200 From: 'Christoph Hellwig' To: Robin Murphy Subject: Re: [PATCH 16/16] dma-mapping: use exact allocation in dma_alloc_contiguous Message-ID: <20190614150827.GA9460@lst.de> References: <20190614134726.3827-1-hch@lst.de> <20190614134726.3827-17-hch@lst.de> <20190614145001.GB9088@lst.de> <4113cd5f-5c13-e9c7-bc5e-dcf0b60e7054@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <4113cd5f-5c13-e9c7-bc5e-dcf0b60e7054@arm.com> User-Agent: Mutt/1.5.17 (2007-11-01) Cc: Maxime Ripard , Joonas Lahtinen , "dri-devel@lists.freedesktop.org" , "linux-mm@kvack.org" , 'Christoph Hellwig' , "devel@driverdev.osuosl.org" , "linux-s390@vger.kernel.org" , "linux-rdma@vger.kernel.org" , David Airlie , "linux-media@vger.kernel.org" , Intel Linux Wireless , "intel-gfx@lists.freedesktop.org" , Maarten Lankhorst , Jani Nikula , Ian Abbott , Rodrigo Vivi , Sean Paul , "moderated list:ARM PORT" , "netdev@vger.kernel.org" , "linux-wireless@vger.kernel.org" , "linux-kernel@vger.kernel.org" , H Hartley Sweeten , "iommu@lists.linux-foundation.org" , David Laight , Daniel Vetter X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: iommu-bounces@lists.linux-foundation.org Errors-To: iommu-bounces@lists.linux-foundation.org On Fri, Jun 14, 2019 at 04:05:33PM +0100, Robin Murphy wrote: > That said, I don't believe this particular patch should make any > appreciable difference - alloc_pages_exact() is still going to give back > the same base address as the rounded up over-allocation would, and > PAGE_ALIGN()ing the size passed to get_order() already seemed to be > pointless. True, we actually do get the right alignment just about anywhere. Not 100% sure about the various static pool implementations, but we can make sure if any didn't we'll do that right thing once those get consolidated. _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu