Re: [PATCH v2] iommu: add support for drivers that manage iommu explicitly

Rob Clark
2019-07-22T15:41:58Z

On Mon, Jul 22, 2019 at 7:28 AM Joerg Roedel <joro@8bytes.org> wrote:
>
> On Wed, Jul 10, 2019 at 11:28:30AM -0700, Rob Clark wrote:
> > --- a/include/linux/device.h
> > +++ b/include/linux/device.h
> > @@ -282,7 +282,8 @@ struct device_driver {
> > struct module *owner;
> > const char *mod_name; /* used for built-in modules */
> >
> > - bool suppress_bind_attrs; /* disables bind/unbind via sysfs */
> > + bool suppress_bind_attrs:1; /* disables bind/unbind via sysfs */
> > + bool driver_manages_iommu:1; /* driver manages IOMMU explicitly */
>
> Who will set this bit?
>

It is set by the driver:

https://patchwork.freedesktop.org/patch/315291/

(This doesn't really belong in devicetree, since it isn't a
description of the hardware, so the driver is really the only place to
set this.. which is fine because it is about a detail of how the
driver works.)

BR,
-R