From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35B70C76190 for ; Mon, 22 Jul 2019 15:12:05 +0000 (UTC) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 135C021911 for ; Mon, 22 Jul 2019 15:12:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 135C021911 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=8bytes.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id CDE75C5C; Mon, 22 Jul 2019 15:12:04 +0000 (UTC) Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 93FD2C58 for ; Mon, 22 Jul 2019 15:12:03 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from theia.8bytes.org (8bytes.org [81.169.241.247]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 30362224 for ; Mon, 22 Jul 2019 15:11:55 +0000 (UTC) Received: by theia.8bytes.org (Postfix, from userid 1000) id 330FA447; Mon, 22 Jul 2019 17:11:53 +0200 (CEST) Date: Mon, 22 Jul 2019 17:11:51 +0200 From: Joerg Roedel To: Sai Praneeth Prakhya Subject: Re: [PATCH RFC 1/4] iommu/vt-d: Modify device_def_domain_type() to use at runtime Message-ID: <20190722151151.GD12009@8bytes.org> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Cc: Ashok Raj , Will Deacon , iommu@lists.linux-foundation.org, Robin Murphy , Christoph Hellwig X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: iommu-bounces@lists.linux-foundation.org Errors-To: iommu-bounces@lists.linux-foundation.org On Tue, Jul 02, 2019 at 06:53:59PM -0700, Sai Praneeth Prakhya wrote: > device_def_domain_type() determines the domain type a device could have and > it's called only during boot. But, to change the domain of a group through > sysfs, kernel has to call this function during runtime. Hence, add an > argument to the function which lets the function know if it's being called > at boot time or runtime. I don't think it should make a difference when the function is actually called. The sysfs input is just another variable to take into account when the default domain type is determined. What I'd like to see for example is that I can write 'auto' to the file and get back the systems decision for the default domain type. I'd also like to be able to forbid changing the type for e.g. Thunderbolt connected devices. Regards, Joerg _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu