From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41B6DC7618B for ; Fri, 26 Jul 2019 06:30:30 +0000 (UTC) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1E75A217D4 for ; Fri, 26 Jul 2019 06:30:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1E75A217D4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id EC908B6C; Fri, 26 Jul 2019 06:30:29 +0000 (UTC) Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 3E6FBB59 for ; Fri, 26 Jul 2019 06:30:29 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id B1661709 for ; Fri, 26 Jul 2019 06:30:28 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id CEB8F227A81; Fri, 26 Jul 2019 08:30:25 +0200 (CEST) Date: Fri, 26 Jul 2019 08:30:25 +0200 From: Christoph Hellwig To: Nicolin Chen Subject: Re: [PATCH 2/2] dma-contiguous: page-align the size in dma_free_contiguous() Message-ID: <20190726063025.GF22881@lst.de> References: <20190725233959.15129-1-nicoleotsuka@gmail.com> <20190725233959.15129-3-nicoleotsuka@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190725233959.15129-3-nicoleotsuka@gmail.com> User-Agent: Mutt/1.5.17 (2007-11-01) Cc: dafna.hirschfeld@collabora.com, linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, robin.murphy@arm.com, hch@lst.de X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: iommu-bounces@lists.linux-foundation.org Errors-To: iommu-bounces@lists.linux-foundation.org On Thu, Jul 25, 2019 at 04:39:59PM -0700, Nicolin Chen wrote: > According to the original dma_direct_alloc_pages() code: > { > unsigned int count = PAGE_ALIGN(size) >> PAGE_SHIFT; > > if (!dma_release_from_contiguous(dev, page, count)) > __free_pages(page, get_order(size)); > } > > The count parameter for dma_release_from_contiguous() was page > aligned before the right-shifting operation, while the new API > dma_free_contiguous() forgets to have PAGE_ALIGN() at the size. > > So this patch simply adds it to prevent any corner case. > > Fixes: fdaeec198ada ("dma-contiguous: add dma_{alloc,free}_contiguous() helpers") > Signed-off-by: Nicolin Chen Looks good, Reviewed-by: Christoph Hellwig _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu