From: Hillf Danton <hdanton@sina.com>
To: Christoph Hellwig <hch@lst.de>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"ath10k@lists.infradead.org" <ath10k@lists.infradead.org>,
Nicolin Chen <nicoleotsuka@gmail.com>,
"iommu@lists.linux-foundation.org"
<iommu@lists.linux-foundation.org>,
"tobias.klausmann@freenet.de" <tobias.klausmann@freenet.de>,
Tobias Klausmann <tobias.johannes.klausmann@mni.thm.de>,
"robin.murphy@arm.com" <robin.murphy@arm.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"kvalo@codeaurora.org" <kvalo@codeaurora.org>
Subject: Re: regression in ath10k dma allocation
Date: Tue, 20 Aug 2019 10:29:35 +0800 [thread overview]
Message-ID: <20190820022935.7016-1-hdanton@sina.com> (raw)
On Tue, 20 Aug 2019 10:15:01 +0800 Christoph Hellwig wrote:
> On Mon, Aug 19, 2019 at 06:58:52PM -0700, Nicolin Chen wrote:
> > Right...the condition was in-between. However, not every caller
> > of dma_alloc_contiguous() is supposed to have a coherent check.
> > So we either add a 'bool coherent_ok' to the API or revert the
> > dma-direct part back to the original. Probably former option is
> > better?
> >
> > Thank you for the debugging. I have been a bit distracted, may
> > not be able to submit a fix very soon. Would you like to help?
>
> Yeah, it turns out that while the idea for the dma_alloc_contiguous
> helper was neat it didn't work out at all, and me pushing Nicolin
> down that route was not a very smart idea. Sorry for causing this
> mess.
>
> I think we'll just need to open code it for dma-direct for 5.3.
> Hillf do you want to cook up a patch or should I do it?
Feel free to do that, Sir.
Thanks
Hillf
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next reply other threads:[~2019-08-20 2:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-20 2:29 Hillf Danton [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-08-16 16:08 regression in ath10k dma allocation Tobias Klausmann
2019-08-16 16:43 ` Christoph Hellwig
2019-08-16 20:16 ` Tobias Klausmann
2019-08-16 22:25 ` Nicolin Chen
2019-08-16 22:42 ` Tobias Klausmann
2019-08-18 3:13 ` Hillf Danton
2019-08-18 22:38 ` Tobias Klausmann
2019-08-20 1:58 ` Nicolin Chen
2019-08-20 2:14 ` Christoph Hellwig
2019-08-20 3:05 ` Christoph Hellwig
2019-08-20 6:58 ` Hillf Danton
2019-08-20 7:12 ` Christoph Hellwig
2019-08-20 20:24 ` Tobias Klausmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190820022935.7016-1-hdanton@sina.com \
--to=hdanton@sina.com \
--cc=ath10k@lists.infradead.org \
--cc=davem@davemloft.net \
--cc=hch@lst.de \
--cc=iommu@lists.linux-foundation.org \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nicoleotsuka@gmail.com \
--cc=robin.murphy@arm.com \
--cc=tobias.johannes.klausmann@mni.thm.de \
--cc=tobias.klausmann@freenet.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox