From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03812C4740A for ; Tue, 10 Sep 2019 08:14:21 +0000 (UTC) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BB94B21D7D for ; Tue, 10 Sep 2019 08:14:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BB94B21D7D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=8bytes.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id 9A72CE70; Tue, 10 Sep 2019 08:14:20 +0000 (UTC) Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 77A17E6C for ; Tue, 10 Sep 2019 08:14:19 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from theia.8bytes.org (8bytes.org [81.169.241.247]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 1CFEE82B for ; Tue, 10 Sep 2019 08:14:19 +0000 (UTC) Received: by theia.8bytes.org (Postfix, from userid 1000) id 4DC20386; Tue, 10 Sep 2019 10:14:17 +0200 (CEST) Date: Tue, 10 Sep 2019 10:14:15 +0200 From: Joerg Roedel To: Rob Clark Subject: Re: [PATCH v2 1/2] iommu: add support for drivers that manage iommu explicitly Message-ID: <20190910081415.GB3247@8bytes.org> References: <20190906214409.26677-1-robdclark@gmail.com> <20190906214409.26677-2-robdclark@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190906214409.26677-2-robdclark@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Cc: Rob Clark , Heikki Krogerus , Arnd Bergmann , Suzuki K Poulose , linux-arm-msm@vger.kernel.org, Bartosz Golaszewski , "Rafael J. Wysocki" , Rasmus Villemoes , Robin Murphy , dri-devel@lists.freedesktop.org, Sudeep Holla , iommu@lists.linux-foundation.org, Greg Kroah-Hartman , Joe Perches , Andrew Morton , Will Deacon , open list X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: iommu-bounces@lists.linux-foundation.org Errors-To: iommu-bounces@lists.linux-foundation.org On Fri, Sep 06, 2019 at 02:44:01PM -0700, Rob Clark wrote: > @@ -674,7 +674,7 @@ int iommu_group_add_device(struct iommu_group *group, struct device *dev) > > mutex_lock(&group->mutex); > list_add_tail(&device->list, &group->devices); > - if (group->domain) > + if (group->domain && !(dev->driver && dev->driver->driver_manages_iommu)) Hmm, this code usually runs at enumeration time when no driver is attached to the device. Actually it would be pretty dangerous when this code runs while a driver is attached to the device. How does that change make things work for you? Regards, Joerg _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu