From: Joerg Roedel <joro@8bytes.org>
To: Christoph Hellwig <hch@lst.de>
Cc: arnd@arndb.de, stephan@gerhold.net, linux-kernel@vger.kernel.org,
iommu@lists.linux-foundation.org, natechancellor@gmail.com,
Robin Murphy <robin.murphy@arm.com>,
nsaenzjulienne@suse.de
Subject: Re: [PATCH v2] iommu/dma: Rationalise types for DMA masks
Date: Tue, 17 Dec 2019 11:18:00 +0100 [thread overview]
Message-ID: <20191217101800.GL8689@8bytes.org> (raw)
In-Reply-To: <20191211190235.GA17854@lst.de>
On Wed, Dec 11, 2019 at 08:02:35PM +0100, Christoph Hellwig wrote:
> On Wed, Dec 11, 2019 at 06:33:26PM +0000, Robin Murphy wrote:
> > Since iommu_dma_alloc_iova() combines incoming masks with the u64 bus
> > limit, it makes more sense to pass them around in their native u64
> > rather than converting to dma_addr_t early. Do that, and resolve the
> > remaining type discrepancy against the domain geometry with a cheeky
> > cast to keep things simple.
> >
> > Signed-off-by: Robin Murphy <robin.murphy@arm.com>
>
> Looks good to me:
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
>
> Joerg, let me know if you want to pick this up through the iommu tree as
> it touches the iommu code, or through the dma-mapping tree that
> introduced the warning.
I'll take it through my tree, as I am about to collect fixes anyway.
Patch is now applied, thanks everyone.
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2019-12-17 10:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-11 18:33 [PATCH v2] iommu/dma: Rationalise types for DMA masks Robin Murphy
2019-12-11 19:02 ` Christoph Hellwig
2019-12-17 10:18 ` Joerg Roedel [this message]
2019-12-11 19:07 ` Nathan Chancellor
2019-12-11 19:12 ` Nicolas Saenz Julienne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191217101800.GL8689@8bytes.org \
--to=joro@8bytes.org \
--cc=arnd@arndb.de \
--cc=hch@lst.de \
--cc=iommu@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=natechancellor@gmail.com \
--cc=nsaenzjulienne@suse.de \
--cc=robin.murphy@arm.com \
--cc=stephan@gerhold.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox