From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFAC7C43603 for ; Tue, 17 Dec 2019 10:48:45 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C940B2072D for ; Tue, 17 Dec 2019 10:48:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C940B2072D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 95C3F865C1; Tue, 17 Dec 2019 10:48:45 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gtpIg-SNr+1i; Tue, 17 Dec 2019 10:48:44 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by whitealder.osuosl.org (Postfix) with ESMTP id CF4F58633E; Tue, 17 Dec 2019 10:48:44 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id B5A11C1AE8; Tue, 17 Dec 2019 10:48:44 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists.linuxfoundation.org (Postfix) with ESMTP id 6C100C077D for ; Tue, 17 Dec 2019 10:48:43 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 4FBEB2043A for ; Tue, 17 Dec 2019 10:48:43 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id TIHX-CV5AtBk for ; Tue, 17 Dec 2019 10:48:42 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by silver.osuosl.org (Postfix) with ESMTPS id EE94E203F1 for ; Tue, 17 Dec 2019 10:48:41 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id BEEF4ADA1; Tue, 17 Dec 2019 10:48:39 +0000 (UTC) Date: Tue, 17 Dec 2019 11:48:38 +0100 From: Joerg Roedel To: Lu Baolu Subject: Re: [PATCH] iommu/vt-d: Allocate reserved region for ISA with correct permission Message-ID: <20191217104838.GC28651@suse.de> References: <20191213053642.5696-1-jsnitsel@redhat.com> <3a9bcdc5-9e78-945d-f6e4-5af6829bf4f0@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <3a9bcdc5-9e78-945d-f6e4-5af6829bf4f0@linux.intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On Sun, Dec 15, 2019 at 01:39:31PM +0800, Lu Baolu wrote: > Hi, > > On 12/13/19 1:36 PM, Jerry Snitselaar wrote: > > Currently the reserved region for ISA is allocated with no > > permissions. If a dma domain is being used, mapping this region will > > fail. Set the permissions to DMA_PTE_READ|DMA_PTE_WRITE. > > > > Cc: Joerg Roedel > > Cc: Lu Baolu > > Cc: iommu@lists.linux-foundation.org > > Cc: stable@vger.kernel.org # v5.3+ > > Fixes: d850c2ee5fe2 ("iommu/vt-d: Expose ISA direct mapping region via iommu_get_resv_regions") > > Signed-off-by: Jerry Snitselaar > > This fix looks reasonable to me. > > Acked-by: Lu Baolu Applied for v5.5, thanks. _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu