From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, FAKE_REPLY_C,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C0E0C43603 for ; Fri, 20 Dec 2019 15:03:22 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 31C00222C2 for ; Fri, 20 Dec 2019 15:03:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="cY0BevEb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 31C00222C2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 12D98870B3; Fri, 20 Dec 2019 15:03:22 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0P_Erp7T20DB; Fri, 20 Dec 2019 15:03:20 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by fraxinus.osuosl.org (Postfix) with ESMTP id DAD9887072; Fri, 20 Dec 2019 15:03:20 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id BB2E7C18DC; Fri, 20 Dec 2019 15:03:20 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists.linuxfoundation.org (Postfix) with ESMTP id 77EC9C077D for ; Fri, 20 Dec 2019 15:03:19 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 6022A20399 for ; Fri, 20 Dec 2019 15:03:19 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id h0IpnhZL1JrG for ; Fri, 20 Dec 2019 15:03:18 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by silver.osuosl.org (Postfix) with ESMTPS id 01C5A20119 for ; Fri, 20 Dec 2019 15:03:18 +0000 (UTC) Received: from localhost (mobile-166-170-223-177.mycingular.net [166.170.223.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6B35D21655; Fri, 20 Dec 2019 15:03:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576854197; bh=CPY22g81OiRavk7/O94Lph0D5YCaRfHVDFMECFgqwe8=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=cY0BevEbdLDwsL1Ocs55xioO9NT9DJ4cSwjnN9hMVYH8rxx7hewQXPNFXvrgmGRHN HQWw3E8LZhoRR5snduR0sw8QBdkr2bSZQl9mAYCww3KXvlzpiGiUKVCtiDu1/1NQm9 I0XBzXYS8VR8q5pJaAqX06moFepjoThNNAvQycaM= Date: Fri, 20 Dec 2019 09:03:15 -0600 From: Bjorn Helgaas To: Joerg Roedel Subject: Re: [PATCH v4 03/16] PCI/ATS: Restore EXPORT_SYMBOL_GPL() for pci_{enable,disable}_ats() Message-ID: <20191220150315.GA97598@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191220084303.GA9347@8bytes.org> User-Agent: Mutt/1.10.1 (2018-07-13) Cc: iommu@lists.linuxfoundation.org, Jean-Philippe Brucker , Saravana Kannan , Will Deacon , linux-kernel@vger.kernel.org, Ard Biesheuvel , Joerg Roedel , Greg Kroah-Hartman , Greg Kroah-Hartman , kernel-team@android.com, "Isaac J. Manjarres" , Robin Murphy X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On Fri, Dec 20, 2019 at 09:43:03AM +0100, Joerg Roedel wrote: > Hi Bjorn, > > On Thu, Dec 19, 2019 at 12:03:39PM +0000, Will Deacon wrote: > > From: Greg Kroah-Hartman > > > > Commit d355bb209783 ("PCI/ATS: Remove unnecessary EXPORT_SYMBOL_GPL()") > > unexported a bunch of symbols from the PCI core since the only external > > users were non-modular IOMMU drivers. Although most of those symbols > > can remain private for now, 'pci_{enable,disable_ats()' is required for > > the ARM SMMUv3 driver to build as a module, otherwise we get a build > > failure as follows: > > > > | ERROR: "pci_enable_ats" [drivers/iommu/arm-smmu-v3.ko] undefined! > > | ERROR: "pci_disable_ats" [drivers/iommu/arm-smmu-v3.ko] undefined! > > > > Re-export these two functions so that the ARM SMMUv3 driver can be build > > as a module. > > > > Cc: Bjorn Helgaas > > Cc: Joerg Roedel > > Signed-off-by: Greg Kroah-Hartman > > [will: rewrote commit message] > > Signed-off-by: Will Deacon > > --- > > drivers/pci/ats.c | 2 ++ > > 1 file changed, 2 insertions(+) > > Are you fine with this change? I would apply this series to my tree > then. Yep, thanks! You can add my Acked-by: Bjorn Helgaas _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu