From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32335C33CB1 for ; Fri, 17 Jan 2020 10:22:07 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 04C7720730 for ; Fri, 17 Jan 2020 10:22:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 04C7720730 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=8bytes.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id C506F8507B; Fri, 17 Jan 2020 10:22:06 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id mt6h2l28mozc; Fri, 17 Jan 2020 10:22:02 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by whitealder.osuosl.org (Postfix) with ESMTP id 12BE285039; Fri, 17 Jan 2020 10:22:02 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 061C2C18DC; Fri, 17 Jan 2020 10:22:02 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists.linuxfoundation.org (Postfix) with ESMTP id 50979C077D for ; Fri, 17 Jan 2020 10:22:00 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 41136220EF for ; Fri, 17 Jan 2020 10:22:00 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id G326kED+SoXv for ; Fri, 17 Jan 2020 10:21:54 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from theia.8bytes.org (8bytes.org [81.169.241.247]) by silver.osuosl.org (Postfix) with ESMTPS id B639C2040C for ; Fri, 17 Jan 2020 10:21:54 +0000 (UTC) Received: by theia.8bytes.org (Postfix, from userid 1000) id 11BFA327; Fri, 17 Jan 2020 11:21:52 +0100 (CET) Date: Fri, 17 Jan 2020 11:21:51 +0100 From: Joerg Roedel To: Lu Baolu Subject: Re: [RFC PATCH 3/4] iommu: Preallocate iommu group when probing devices Message-ID: <20200117102151.GF15760@8bytes.org> References: <20200101052648.14295-1-baolu.lu@linux.intel.com> <20200101052648.14295-4-baolu.lu@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200101052648.14295-4-baolu.lu@linux.intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Cc: kevin.tian@intel.com, ashok.raj@intel.com, Greg Kroah-Hartman , linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, jacob.jun.pan@intel.com, Bjorn Helgaas , Robin Murphy , Christoph Hellwig X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On Wed, Jan 01, 2020 at 01:26:47PM +0800, Lu Baolu wrote: > This splits iommu group allocation from adding devices. This makes > it possible to determine the default domain type for each group as > all devices belonging to the group have been determined. I think its better to keep group allocation as it is and just defer default domain allocation after each device is in its group. But take care about the device hotplug path which might add new devices to groups which already have a default domain, or add new groups that might need a default domain too. Regards, Joerg _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu