From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C1B0C0044D for ; Mon, 16 Mar 2020 15:43:13 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 57A3D20663 for ; Mon, 16 Mar 2020 15:43:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="gEq8/ZMB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 57A3D20663 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id DD226881FA; Mon, 16 Mar 2020 15:43:12 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id DtOeZG526mFG; Mon, 16 Mar 2020 15:43:12 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by whitealder.osuosl.org (Postfix) with ESMTP id 70227881BC; Mon, 16 Mar 2020 15:43:12 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 51E6DC1D7C; Mon, 16 Mar 2020 15:43:12 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists.linuxfoundation.org (Postfix) with ESMTP id 94039C013E for ; Mon, 16 Mar 2020 15:43:11 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 80010203E8 for ; Mon, 16 Mar 2020 15:43:11 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id FzOrh7xtfF8j for ; Mon, 16 Mar 2020 15:43:09 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by silver.osuosl.org (Postfix) with ESMTPS id F2308203DB for ; Mon, 16 Mar 2020 15:43:08 +0000 (UTC) Received: by mail-wr1-f65.google.com with SMTP id a25so21841641wrd.0 for ; Mon, 16 Mar 2020 08:43:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=DdvuxQV8MUJ3DF0txatG/PoeJXobhfl8uAplHUnRQXw=; b=gEq8/ZMBwfLkBD9tGRHGjZfTd20HP1xHo/lJCYGOxGAYI7JgVG9jMowKPQSyqmQoJH Q9ZbaY7SOKJp8K4eyLHZOG5BXM7bIz0LDg0iLZ0C7XwnSZgO4Q7ql/grJgyu+f0XKKiZ 8hj2Hl5fh1i6wP+q7uq/YnEi3K13FYNSMiMBiMDb9rTjtVKuKwTX2bq22JmdTliOTXP2 K+5zCU0/1lWFBSvTXbDx9fEkSA/zS7i5vKY3n2XrAijwrJW7uI1+D+Ab8wO+LOpxCjFg cLiZ+CoMaM/7tmWRw/RxFAOt/xBIBCD8p1Ekq22vHH0ospnbZ5362hTq6dFil73T5VxH cAwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=DdvuxQV8MUJ3DF0txatG/PoeJXobhfl8uAplHUnRQXw=; b=Rm51ccyeYslXuvIxfEUYg1rKugMnjZr+EATNOxHhDkVBuzbFt3yVrdMdD7id1QPxw2 JMnx0TqwJdk+qomcisYkrVpzxPDvYcwg9xtnsBquhrwFPg5DkjwZj3ToeGDYuL6ok0Og 28coW9qR5BcmnGKnK/WEp5ECCBAeqhYbjy//swhVb/ry8FaE/YjOI0lUphLA80TgYM8k G4cES7w47xKmt8yD3CVTIov8WuEhEOIu4cZOY3dBo2rER9itgl0fQKvyO36rE1bhLcMK wQMJ2jnUot5Ky3Z/fxZxfOd1cqpyOpo3RBeLVQRpSxDtrgOPOEYRan/YqckUC/Oc67a9 XFTw== X-Gm-Message-State: ANhLgQ3B8xWwLvfDidc//EMSpLZ4WsRnsTL4of2MTV1ix3LFz9Bc8bIn iLM/VB1+ETj9wYLVtiVufm8Msg== X-Google-Smtp-Source: ADFU+vukGMBSU+PIquYB6P7V4T5BWKneai54XgateQmlyq1EDcQ3i3rP1F+AK6w2nNtuc0TA4HUjIw== X-Received: by 2002:a5d:43cc:: with SMTP id v12mr35844297wrr.125.1584373387505; Mon, 16 Mar 2020 08:43:07 -0700 (PDT) Received: from myrica ([2001:171b:226b:54a0:116c:c27a:3e7f:5eaf]) by smtp.gmail.com with ESMTPSA id h13sm433117wrv.39.2020.03.16.08.43.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Mar 2020 08:43:07 -0700 (PDT) Date: Mon, 16 Mar 2020 16:42:59 +0100 From: Jean-Philippe Brucker To: Joerg Roedel Subject: Re: [PATCH 04/15] iommu/tegra-gart: Remove direct access of dev->iommu_fwspec Message-ID: <20200316154259.GE304669@myrica> References: <20200310091229.29830-1-joro@8bytes.org> <20200310091229.29830-5-joro@8bytes.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200310091229.29830-5-joro@8bytes.org> Cc: Will Deacon , linux-arm-msm@vger.kernel.org, Sudeep Holla , linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, iommu@lists.linux-foundation.org, Thierry Reding , linux-mediatek@lists.infradead.org, Andy Gross , Joerg Roedel , Hanjun Guo , Matthias Brugger , Bjorn Andersson , Sean Paul , Robin Murphy X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On Tue, Mar 10, 2020 at 10:12:18AM +0100, Joerg Roedel wrote: > From: Joerg Roedel > > Use the accessor functions instead of directly dereferencing > dev->iommu_fwspec. > > Signed-off-by: Joerg Roedel Reviewed-by: Jean-Philippe Brucker > --- > drivers/iommu/tegra-gart.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iommu/tegra-gart.c b/drivers/iommu/tegra-gart.c > index 3fb7ba72507d..db6559e8336f 100644 > --- a/drivers/iommu/tegra-gart.c > +++ b/drivers/iommu/tegra-gart.c > @@ -247,7 +247,7 @@ static int gart_iommu_add_device(struct device *dev) > { > struct iommu_group *group; > > - if (!dev->iommu_fwspec) > + if (!dev_iommu_fwspec_get(dev)) > return -ENODEV; > > group = iommu_group_get_for_dev(dev); > -- > 2.17.1 > _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu