Linux IOMMU Development
 help / color / mirror / Atom feed
From: "Tang Bin" <tangbin@cmss.chinamobile.com>
To: "Bjorn Andersson" <bjorn.andersson@linaro.org>
Cc: linux-arm-msm <linux-arm-msm@vger.kernel.org>,
	iommu <iommu@lists.linux-foundation.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	agross <agross@kernel.org>
Subject: Re: Re: [PATCH] iommu/qcom:fix local_base status check
Date: Wed, 8 Apr 2020 19:27:53 +0800	[thread overview]
Message-ID: <2020040819275303590511@cmss.chinamobile.com> (raw)
In-Reply-To: 20200402064552.GG663905@yoga


[-- Attachment #1.1: Type: text/plain, Size: 1435 bytes --]

> Reviewed-by:Bjorn Andersson <bjorn.andersson@linaro.org>

Thanks for your positive feedback.

Will the patch need any more clarification？Looking forward to your result, thank you!



Regards,
Tang Bin
 
From: Bjorn Andersson
Date: 2020-04-02 14:45
To: Tang Bin
CC: agross; robdclark; joro; linux-arm-msm; iommu; linux-kernel
Subject: Re: [PATCH] iommu/qcom:fix local_base status check
On Wed 01 Apr 23:33 PDT 2020, Tang Bin wrote:
 
> Release resources when exiting on error.
> 
 
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
 
Regards,
Bjorn
 
> Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
> ---
>  drivers/iommu/qcom_iommu.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/iommu/qcom_iommu.c b/drivers/iommu/qcom_iommu.c
> index 4328da0b0..c08aa9651 100644
> --- a/drivers/iommu/qcom_iommu.c
> +++ b/drivers/iommu/qcom_iommu.c
> @@ -813,8 +813,11 @@ static int qcom_iommu_device_probe(struct platform_device *pdev)
>  qcom_iommu->dev = dev;
>  
>  res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - if (res)
> + if (res) {
>  qcom_iommu->local_base = devm_ioremap_resource(dev, res);
> + if (IS_ERR(qcom_iommu->local_base))
> + return PTR_ERR(qcom_iommu->local_base);
> + }
>  
>  qcom_iommu->iface_clk = devm_clk_get(dev, "iface");
>  if (IS_ERR(qcom_iommu->iface_clk)) {
> -- 
> 2.20.1.windows.1
> 
> 
> 

[-- Attachment #1.2: Type: text/html, Size: 4208 bytes --]

[-- Attachment #2: Type: text/plain, Size: 156 bytes --]

_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

  reply	other threads:[~2020-04-08 11:26 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-02  6:33 [PATCH] iommu/qcom:fix local_base status check Tang Bin
2020-04-02  6:45 ` Bjorn Andersson
2020-04-08 11:27   ` Tang Bin [this message]
2020-04-16  6:42   ` Tang Bin
2020-04-18 11:54     ` Joerg Roedel
2020-04-18 13:08       ` Tang Bin
2020-04-16 10:05 ` Robin Murphy
2020-04-16 10:12   ` Tang Bin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2020040819275303590511@cmss.chinamobile.com \
    --to=tangbin@cmss.chinamobile.com \
    --cc=agross@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=iommu@lists.linux-foundation.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox