From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36B94C2BA19 for ; Wed, 15 Apr 2020 15:43:32 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 02A1E20771 for ; Wed, 15 Apr 2020 15:43:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 02A1E20771 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id DC8FF85F2D; Wed, 15 Apr 2020 15:43:31 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id K-vXYXUGjk67; Wed, 15 Apr 2020 15:43:31 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by fraxinus.osuosl.org (Postfix) with ESMTP id 26C0785EF1; Wed, 15 Apr 2020 15:43:31 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id E8783C089E; Wed, 15 Apr 2020 15:43:30 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists.linuxfoundation.org (Postfix) with ESMTP id 58C5DC0172 for ; Wed, 15 Apr 2020 15:43:29 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 3FB1185EF3 for ; Wed, 15 Apr 2020 15:43:29 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wNJPULUCh52F for ; Wed, 15 Apr 2020 15:43:28 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by fraxinus.osuosl.org (Postfix) with ESMTP id EC55185EF1 for ; Wed, 15 Apr 2020 15:43:27 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 145191FB; Wed, 15 Apr 2020 08:43:27 -0700 (PDT) Received: from red-moon.cambridge.arm.com (unknown [10.57.31.189]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 562743F6C4; Wed, 15 Apr 2020 08:43:24 -0700 (PDT) Date: Wed, 15 Apr 2020 16:43:18 +0100 From: Lorenzo Pieralisi To: Makarand Pawagi Subject: Re: [EXT] Re: [RFC PATCH 1/4] bus: fsl-mc: add custom .dma_configure implementation Message-ID: <20200415153901.GA21296@red-moon.cambridge.arm.com> References: <20200227100542.13819-1-laurentiu.tudor@nxp.com> <20200325125109.GA5430@red-moon.cambridge.arm.com> <499fbf9a-416f-d7c7-0655-881d92138a6c@nxp.com> <20200414143211.GA14905@red-moon.cambridge.arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Cc: "jason@lakedaemon.net" , Calvin Johnson , "ard.biesheuvel@linaro.org" , "maz@kernel.org" , Pankaj Bansal , "Diana Madalina Craciun \(OSS\)" , "jon@solid-run.com" , "linux-kernel@vger.kernel.org" , "jeremy.linton@arm.com" , "linux-acpi@vger.kernel.org" , "iommu@lists.linux-foundation.org" , Cristi Sovaiala , "tglx@linutronix.de" , Varun Sethi , Ioana Ciornei , "Stuart.Yoder@arm.com" , "robin.murphy@arm.com" , "linux-arm-kernel@lists.infradead.org" X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On Wed, Apr 15, 2020 at 05:42:03AM +0000, Makarand Pawagi wrote: > > > > -----Original Message----- > > From: Lorenzo Pieralisi > > Sent: Tuesday, April 14, 2020 8:02 PM > > To: Laurentiu Tudor > > Cc: linux-kernel@vger.kernel.org; iommu@lists.linux-foundation.org; linux-arm- > > kernel@lists.infradead.org; linux-acpi@vger.kernel.org; > > robin.murphy@arm.com; ard.biesheuvel@linaro.org; Ioana Ciornei > > ; Diana Madalina Craciun (OSS) > > ; maz@kernel.org; jon@solid-run.com; Pankaj > > Bansal ; Makarand Pawagi > > ; Calvin Johnson ; > > Varun Sethi ; Cristi Sovaiala ; > > Stuart.Yoder@arm.com; jeremy.linton@arm.com; joro@8bytes.org; > > tglx@linutronix.de; jason@lakedaemon.net > > Subject: [EXT] Re: [RFC PATCH 1/4] bus: fsl-mc: add custom .dma_configure > > implementation > > > > Caution: EXT Email > > > > On Wed, Mar 25, 2020 at 06:48:55PM +0200, Laurentiu Tudor wrote: > > > Hi Lorenzo, > > > > > > On 3/25/2020 2:51 PM, Lorenzo Pieralisi wrote: > > > > On Thu, Feb 27, 2020 at 12:05:39PM +0200, laurentiu.tudor@nxp.com wrote: > > > >> From: Laurentiu Tudor > > > >> > > > >> The devices on this bus are not discovered by way of device tree > > > >> but by queries to the firmware. It makes little sense to trick the > > > >> generic of layer into thinking that these devices are of related so > > > >> that we can get our dma configuration. Instead of doing that, add > > > >> our custom dma configuration implementation. > > > >> > > > >> Signed-off-by: Laurentiu Tudor > > > >> --- > > > >> drivers/bus/fsl-mc/fsl-mc-bus.c | 31 > > > >> ++++++++++++++++++++++++++++++- > > > >> 1 file changed, 30 insertions(+), 1 deletion(-) > > > >> > > > >> diff --git a/drivers/bus/fsl-mc/fsl-mc-bus.c > > > >> b/drivers/bus/fsl-mc/fsl-mc-bus.c index 36eb25f82c8e..eafaa0e0b906 > > > >> 100644 > > > >> --- a/drivers/bus/fsl-mc/fsl-mc-bus.c > > > >> +++ b/drivers/bus/fsl-mc/fsl-mc-bus.c > > > >> @@ -132,11 +132,40 @@ static int fsl_mc_bus_uevent(struct device > > > >> *dev, struct kobj_uevent_env *env) static int > > > >> fsl_mc_dma_configure(struct device *dev) { > > > >> struct device *dma_dev = dev; > > > >> + struct iommu_fwspec *fwspec; > > > >> + const struct iommu_ops *iommu_ops; struct fsl_mc_device *mc_dev > > > >> + = to_fsl_mc_device(dev); int ret; > > > >> + u32 icid; > > > >> > > > >> while (dev_is_fsl_mc(dma_dev)) > > > >> dma_dev = dma_dev->parent; > > > >> > > > >> - return of_dma_configure(dev, dma_dev->of_node, 0); > > > >> + fwspec = dev_iommu_fwspec_get(dma_dev); if (!fwspec) > > > >> + return -ENODEV; > > > >> + iommu_ops = iommu_ops_from_fwnode(fwspec->iommu_fwnode); > > > >> + if (!iommu_ops) > > > >> + return -ENODEV; > > > >> + > > > >> + ret = iommu_fwspec_init(dev, fwspec->iommu_fwnode, iommu_ops); > > > >> + if (ret) > > > >> + return ret; > > > >> + > > > >> + icid = mc_dev->icid; > > > >> + ret = iommu_fwspec_add_ids(dev, &icid, 1); > > > > > > > > I see. So with this patch we would use the MC named component only > > > > to retrieve the iommu_ops > > > > > > Right. I'd also add that the implementation tries to follow the > > > existing standard .dma_configure implementations, e.g. > > > of_dma_configure + of_iommu_configure. I'd also note that similarly to > > > the ACPI case, this MC FW device is probed as a platform device in the > > > DT scenario, binding here [1]. > > > A similar approach is used for the retrieval of the msi irq domain, > > > see following patch. > > > > > > > - the streamid are injected directly here bypassing OF/IORT bindings > > translations altogether. > > > > > > Actually I've submitted a v2 [2] that calls into .of_xlate() to allow > > > the smmu driver to do some processing on the raw streamid coming from > > > the firmware. I have not yet tested this with ACPI but expect it to > > > work, however, it's debatable how valid is this approach in the > > > context of ACPI. > > > > Actually, what I think you need is of_map_rid() (and an IORT equivalent, that I > > am going to write - generalizing iort_msi_map_rid()). > > > > That would help. > > > Would that be enough to enable IORT "normal" mappings in the MC bus named > > components ? > > > > But still the question remain unanswered that how we are going to represent MC? As Platform device with single ID mapping flag? No, "normal" mappings, that's what I wrote above and it is not a platform device it is a named component in ACPI/IORT terms. Thanks, Lorenzo _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu