From: Christoph Hellwig <hch@lst.de>
To: Tom Lendacky <thomas.lendacky@amd.com>
Cc: x86@kernel.org, Brijesh Singh <brijesh.singh@amd.com>,
Jon Grimm <jon.grimm@amd.com>,
linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
David Rientjes <rientjes@google.com>,
Thomas Gleixner <tglx@linutronix.de>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [patch 5/7] dma-pool: add pool sizes to debugfs
Date: Fri, 17 Apr 2020 09:10:23 +0200 [thread overview]
Message-ID: <20200417071023.GC19153@lst.de> (raw)
In-Reply-To: <0c7144e3-057a-959d-0b7d-4a718bd6076c@amd.com>
On Wed, Apr 15, 2020 at 08:45:08AM -0500, Tom Lendacky wrote:
>
>
> On 4/14/20 7:04 PM, David Rientjes wrote:
>> The atomic DMA pools can dynamically expand based on non-blocking
>> allocations that need to use it.
>>
>> Export the sizes of each of these pools, in bytes, through debugfs for
>> measurement.
>>
>> Suggested-by: Christoph Hellwig <hch@lst.de>
>> Signed-off-by: David Rientjes <rientjes@google.com>
>> ---
>> kernel/dma/pool.c | 41 +++++++++++++++++++++++++++++++++++++++++
>> 1 file changed, 41 insertions(+)
>>
>> diff --git a/kernel/dma/pool.c b/kernel/dma/pool.c
>> index cf052314d9e4..3e22022c933b 100644
>> --- a/kernel/dma/pool.c
>> +++ b/kernel/dma/pool.c
>> @@ -2,6 +2,7 @@
>> /*
>> * Copyright (C) 2020 Google LLC
>> */
>> +#include <linux/debugfs.h>
>> #include <linux/dma-direct.h>
>> #include <linux/dma-noncoherent.h>
>> #include <linux/dma-contiguous.h>
>> @@ -15,6 +16,11 @@
>> static struct gen_pool *atomic_pool_dma __ro_after_init;
>> static struct gen_pool *atomic_pool_dma32 __ro_after_init;
>> static struct gen_pool *atomic_pool_kernel __ro_after_init;
>> +#ifdef CONFIG_DEBUG_FS
>
> I don't think you need the #ifdef any more unless you just want to save
> space. All of the debugfs routines have versions for whether
> CONFIG_DEBUG_FS is defined or not.
Agreed. I can fix this up.
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2020-04-17 7:10 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-15 0:04 [patch 0/7] unencrypted atomic DMA pools with dynamic expansion David Rientjes via iommu
2020-04-15 0:04 ` [patch 1/7] dma-remap: separate DMA atomic pools from direct remap code David Rientjes via iommu
2020-04-17 7:06 ` Christoph Hellwig
2020-04-15 0:04 ` [patch 2/7] dma-pool: add additional coherent pools to map to gfp mask David Rientjes via iommu
2020-04-15 0:04 ` [patch 3/7] dma-pool: dynamically expanding atomic pools David Rientjes via iommu
2020-04-15 0:04 ` [patch 4/7] dma-direct: atomic allocations must come from atomic coherent pools David Rientjes via iommu
2020-04-17 7:09 ` Christoph Hellwig
2020-04-15 0:04 ` [patch 5/7] dma-pool: add pool sizes to debugfs David Rientjes via iommu
2020-04-15 13:45 ` Tom Lendacky
2020-04-17 7:10 ` Christoph Hellwig [this message]
2020-04-15 0:05 ` [patch 6/7] x86/mm: unencrypted non-blocking DMA allocations use coherent pools David Rientjes via iommu
2020-04-15 0:05 ` [patch 7/7] dma-pool: scale the default DMA coherent pool size with memory capacity David Rientjes via iommu
2020-04-17 7:11 ` [patch 0/7] unencrypted atomic DMA pools with dynamic expansion Christoph Hellwig
2020-04-17 18:41 ` David Rientjes via iommu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200417071023.GC19153@lst.de \
--to=hch@lst.de \
--cc=bp@alien8.de \
--cc=brijesh.singh@amd.com \
--cc=iommu@lists.linux-foundation.org \
--cc=jon.grimm@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rientjes@google.com \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).