* Re: [PATCH] dma-debug: make __dma_entry_alloc_check_leak() static
2020-04-17 7:36 [PATCH] dma-debug: make __dma_entry_alloc_check_leak() static Jason Yan
@ 2020-04-17 7:13 ` Christoph Hellwig
0 siblings, 0 replies; 2+ messages in thread
From: Christoph Hellwig @ 2020-04-17 7:13 UTC (permalink / raw)
To: Jason Yan; +Cc: linux-kernel, Hulk Robot, iommu, robin.murphy, hch
On Fri, Apr 17, 2020 at 03:36:05PM +0800, Jason Yan wrote:
> Fix the following sparse warning:
>
> kernel/dma/debug.c:659:6: warning: symbol '__dma_entry_alloc_check_leak'
> was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
Looks good, I'll queue this up for 5.8.
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH] dma-debug: make __dma_entry_alloc_check_leak() static
@ 2020-04-17 7:36 Jason Yan
2020-04-17 7:13 ` Christoph Hellwig
0 siblings, 1 reply; 2+ messages in thread
From: Jason Yan @ 2020-04-17 7:36 UTC (permalink / raw)
To: hch, m.szyprowski, robin.murphy, iommu, linux-kernel
Cc: Hulk Robot, Jason Yan
Fix the following sparse warning:
kernel/dma/debug.c:659:6: warning: symbol '__dma_entry_alloc_check_leak'
was not declared. Should it be static?
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Jason Yan <yanaijie@huawei.com>
---
kernel/dma/debug.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/dma/debug.c b/kernel/dma/debug.c
index 9e1777c81f55..36c962a86bf2 100644
--- a/kernel/dma/debug.c
+++ b/kernel/dma/debug.c
@@ -656,7 +656,7 @@ static struct dma_debug_entry *__dma_entry_alloc(void)
return entry;
}
-void __dma_entry_alloc_check_leak(void)
+static void __dma_entry_alloc_check_leak(void)
{
u32 tmp = nr_total_entries % nr_prealloc_entries;
--
2.21.1
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-04-17 7:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-04-17 7:36 [PATCH] dma-debug: make __dma_entry_alloc_check_leak() static Jason Yan
2020-04-17 7:13 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).