From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90038C2D0EF for ; Sat, 18 Apr 2020 11:54:12 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5B98020780 for ; Sat, 18 Apr 2020 11:54:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5B98020780 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=8bytes.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 221F287711; Sat, 18 Apr 2020 11:54:12 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qyBwwpKmeLX9; Sat, 18 Apr 2020 11:54:11 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by whitealder.osuosl.org (Postfix) with ESMTP id 4434A87456; Sat, 18 Apr 2020 11:54:11 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 32B17C089F; Sat, 18 Apr 2020 11:54:11 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists.linuxfoundation.org (Postfix) with ESMTP id 51D78C0172 for ; Sat, 18 Apr 2020 11:54:08 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 3B1C388222 for ; Sat, 18 Apr 2020 11:54:08 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0uWhyst8h9JP for ; Sat, 18 Apr 2020 11:54:06 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from theia.8bytes.org (8bytes.org [81.169.241.247]) by hemlock.osuosl.org (Postfix) with ESMTPS id 0E80B88216 for ; Sat, 18 Apr 2020 11:54:06 +0000 (UTC) Received: by theia.8bytes.org (Postfix, from userid 1000) id F25AB342; Sat, 18 Apr 2020 13:54:02 +0200 (CEST) Date: Sat, 18 Apr 2020 13:54:00 +0200 From: Joerg Roedel To: Tang Bin Subject: Re: [PATCH] iommu/qcom:fix local_base status check Message-ID: <20200418115400.GF21900@8bytes.org> References: <20200402063302.20640-1-tangbin@cmss.chinamobile.com> <20200402064552.GG663905@yoga> <7a565c74-f223-83da-cf32-0474be6c9460@cmss.chinamobile.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <7a565c74-f223-83da-cf32-0474be6c9460@cmss.chinamobile.com> User-Agent: Mutt/1.10.1 (2018-07-13) Cc: linux-arm-msm@vger.kernel.org, iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, agross@kernel.org, Bjorn Andersson X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On Thu, Apr 16, 2020 at 02:42:23PM +0800, Tang Bin wrote: > =A0=A0=A0=A0=A0=A0=A0 The function qcom_iommu_device_probe() does not per= form sufficient > error checking after executing devm_ioremap_resource(), which can result = in > crashes if a critical error path is encountered. > = > Fixes: 0ae349a0("iommu/qcom: Add qcom_iommu") Yes, that sounds better. Please use it for the commit message and also add the Fixes line and resubmit the fix to me. Please make the fixes line: Fixes: 0ae349a0f33f ("iommu/qcom: Add qcom_iommu") So that the commit-id is 12 characters long and a space between it and the subject. Thanks, Joerg _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu