From: Christoph Hellwig <hch@lst.de>
To: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: Thomas Zimmermann <tzimmermann@suse.de>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
David Airlie <airlied@linux.ie>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
linaro-mm-sig@lists.linaro.org, iommu@lists.linux-foundation.org,
Maxime Ripard <mripard@kernel.org>,
Daniel Vetter <daniel@ffwll.ch>,
Robin Murphy <robin.murphy@arm.com>,
Christoph Hellwig <hch@lst.de>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 02/25] drm: core: fix common struct sg_table related issues
Date: Tue, 5 May 2020 13:09:50 +0200 [thread overview]
Message-ID: <20200505110950.GA19067@lst.de> (raw)
In-Reply-To: <5dd1cb55-accb-0dc6-4ca5-90c57cd19527@samsung.com>
On Tue, May 05, 2020 at 12:51:58PM +0200, Marek Szyprowski wrote:
> Hi Christoph,
>
> On 05.05.2020 12:15, Christoph Hellwig wrote:
> >> - for_each_sg_page(st->sgl, &sg_iter, st->nents, 0)
> >> + for_each_sg_page(st->sgl, &sg_iter, st->orig_nents, 0)
> > Would it make sense to also add a for_each_sgtable_page helper that
> > hides the use of orig_nents? To be used like:
> >
> > for_each_sgtable_page(st, &sg_iter, 0) {
>
> We would need two helpers:
>
> for_each_sgtable_cpu_page() and for_each_sgtable_dma_page().
>
> I considered them, but then I found that there are already
> for_each_sg_page(), for_each_sg_dma_page() and various special iterators
> like sg_page_iter, sg_dma_page_iter and sg_mapping_iter. Too bad that
> they are almost not used, at least in the DRM subsystem. I wonder if it
> make sense to apply them or simply provide the two above mentioned
> wrappers?
None of the helpers helps with passing the right parameters from the
sg_table. So in doube we'd need wrappers for all of the above, or
none..
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2020-05-05 11:09 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200505084308eucas1p1aa040c3ae325a6c7d92f956b1f5aad0d@eucas1p1.samsung.com>
2020-05-05 8:43 ` [PATCH v3 00/25] DRM: fix struct sg_table nents vs. orig_nents misuse Marek Szyprowski
2020-05-05 8:45 ` [PATCH v3 01/25] dma-mapping: add generic helpers for mapping sgtable objects Marek Szyprowski
2020-05-05 8:45 ` [PATCH v3 02/25] drm: core: fix common struct sg_table related issues Marek Szyprowski
2020-05-05 10:15 ` Christoph Hellwig
2020-05-05 10:51 ` Marek Szyprowski
2020-05-05 11:09 ` Christoph Hellwig [this message]
2020-05-08 7:12 ` Marek Szyprowski
2020-05-08 7:16 ` Christoph Hellwig
2020-05-12 9:05 ` Marek Szyprowski
2020-05-05 8:45 ` [PATCH v3 03/25] drm: amdgpu: " Marek Szyprowski
2020-05-05 8:45 ` [PATCH v3 04/25] drm: armada: " Marek Szyprowski
2020-05-05 8:45 ` [PATCH v3 05/25] drm: etnaviv: " Marek Szyprowski
2020-05-05 8:45 ` [PATCH v3 06/25] drm: exynos: " Marek Szyprowski
2020-05-05 8:45 ` [PATCH v3 07/25] drm: i915: " Marek Szyprowski
2020-05-05 8:45 ` [PATCH v3 08/25] drm: lima: " Marek Szyprowski
2020-05-05 8:45 ` [PATCH v3 09/25] drm: msm: " Marek Szyprowski
2020-05-05 8:45 ` [PATCH v3 10/25] drm: panfrost: " Marek Szyprowski
2020-05-11 15:51 ` Steven Price
2020-05-05 8:46 ` [PATCH v3 11/25] drm: radeon: " Marek Szyprowski
2020-05-05 8:46 ` [PATCH v3 12/25] drm: rockchip: " Marek Szyprowski
2020-05-05 8:46 ` [PATCH v3 13/25] drm: tegra: " Marek Szyprowski
2020-05-05 8:46 ` [PATCH v3 14/25] drm: virtio: " Marek Szyprowski
2020-05-05 8:46 ` [PATCH v3 15/25] drm: vmwgfx: " Marek Szyprowski
2020-05-12 0:19 ` [Linux-graphics-maintainer] " Roland Scheidegger
2020-05-05 8:46 ` [PATCH v3 16/25] xen: gntdev: " Marek Szyprowski
2020-05-05 8:46 ` [PATCH v3 17/25] drm: host1x: " Marek Szyprowski
2020-05-05 8:46 ` [PATCH v3 18/25] drm: rcar-du: " Marek Szyprowski
2020-05-05 9:24 ` Geert Uytterhoeven
2020-05-05 8:46 ` [PATCH v3 19/25] dmabuf: " Marek Szyprowski
2020-05-05 8:46 ` [PATCH v3 20/25] staging: ion: " Marek Szyprowski
2020-05-05 8:46 ` [PATCH v3 21/25] staging: tegra-vde: " Marek Szyprowski
2020-05-05 8:46 ` [PATCH v3 22/25] misc: fastrpc: " Marek Szyprowski
2020-05-05 8:46 ` [PATCH v3 23/25] rapidio: " Marek Szyprowski
2020-05-05 8:46 ` [PATCH v3 24/25] samples: vfio-mdev/mbochs: " Marek Szyprowski
2020-05-05 8:46 ` [PATCH v3 25/25] media: pci: fix common ALSA DMA-mapping related codes Marek Szyprowski
2020-05-05 10:22 ` [PATCH v3 01/25] dma-mapping: add generic helpers for mapping sgtable objects Christoph Hellwig
2020-05-05 10:44 ` Marek Szyprowski
2020-05-07 8:47 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200505110950.GA19067@lst.de \
--to=hch@lst.de \
--cc=airlied@linux.ie \
--cc=b.zolnierkie@samsung.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=iommu@lists.linux-foundation.org \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=robin.murphy@arm.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox