From: Jean-Philippe Brucker <jean-philippe@linaro.org>
To: Julia Lawall <Julia.Lawall@inria.fr>
Cc: eugene.volanschi@inria.fr, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org,
iommu@lists.linux-foundation.org
Subject: Re: [PATCH] iommu/virtio: reverse arguments to list_add
Date: Wed, 6 May 2020 11:35:24 +0200 [thread overview]
Message-ID: <20200506093524.GA497896@myrica> (raw)
In-Reply-To: <1588704467-13431-1-git-send-email-Julia.Lawall@inria.fr>
On Tue, May 05, 2020 at 08:47:47PM +0200, Julia Lawall wrote:
> Elsewhere in the file, there is a list_for_each_entry with
> &vdev->resv_regions as the second argument, suggesting that
> &vdev->resv_regions is the list head. So exchange the
> arguments on the list_add call to put the list head in the
> second argument.
>
> Fixes: 2a5a31487445 ("iommu/virtio: Add probe request")
> Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
Thanks for the fix. The reason this hasn't blown up so far is
iommu_alloc_resv_region() initializes region->list, but adding more than
one item would break the list.
Reviewed-by: Jean-Philippe Brucker <jean-philippe@linaro.org>
> ---
> drivers/iommu/virtio-iommu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iommu/virtio-iommu.c b/drivers/iommu/virtio-iommu.c
> index d5cac4f46ca5..4e1d11af23c8 100644
> --- a/drivers/iommu/virtio-iommu.c
> +++ b/drivers/iommu/virtio-iommu.c
> @@ -453,7 +453,7 @@ static int viommu_add_resv_mem(struct viommu_endpoint *vdev,
> if (!region)
> return -ENOMEM;
>
> - list_add(&vdev->resv_regions, ®ion->list);
> + list_add(®ion->list, &vdev->resv_regions);
> return 0;
> }
>
>
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2020-05-06 9:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-05 18:47 [PATCH] iommu/virtio: reverse arguments to list_add Julia Lawall
2020-05-06 9:35 ` Jean-Philippe Brucker [this message]
2020-05-08 15:31 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200506093524.GA497896@myrica \
--to=jean-philippe@linaro.org \
--cc=Julia.Lawall@inria.fr \
--cc=eugene.volanschi@inria.fr \
--cc=iommu@lists.linux-foundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox