From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4BC57C433DF for ; Mon, 15 Jun 2020 07:53:42 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 171872067B for ; Mon, 15 Jun 2020 07:53:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="AlyICsaS" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 171872067B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 02DB78844A; Mon, 15 Jun 2020 07:53:42 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id CoBalPicV5Sf; Mon, 15 Jun 2020 07:53:41 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by whitealder.osuosl.org (Postfix) with ESMTP id 738E288395; Mon, 15 Jun 2020 07:53:41 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 5A87DC0890; Mon, 15 Jun 2020 07:53:41 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists.linuxfoundation.org (Postfix) with ESMTP id 259F8C016E for ; Mon, 15 Jun 2020 07:53:37 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 0AD992077C for ; Mon, 15 Jun 2020 07:53:37 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Y3TEZ0u4U1Qp for ; Mon, 15 Jun 2020 07:53:36 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by silver.osuosl.org (Postfix) with ESMTPS id 3788A20404 for ; Mon, 15 Jun 2020 07:53:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=NFpMfrG9hSicO32ZjKxBqJx63rGzA3U+MKaGGKR/+vs=; b=AlyICsaSytn6UKQYHxgxKALtpV davZqqhBuoT/RALUO6rpXUvSYemJAE7crjXLyGQz3wbtvJTFfNaoi1Rglp6dVg2CZH9x4sLqemnu+ JklbibNrlyLTx/g+gc6cJqZ8uENDkmFIgntMBecpf7QJUgDOcc4+Tj7zectWHzIWlHd3EuG7t814g +HYj3pC5QDAkoOzs/dcpjIJjYIHYvoTsSP0JEPJ1TUnTQ4+WpbTcVnJyVT/SF1TFsWwxusgVOJ9RB tHGz1xreZFmg2kBRIxtz3nKYW7EGfKHYpY+Xt6vG7x6b7wJGzxfsH3whAUU2bWyLmRByvFylgrVdv DZNY7+/g==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by merlin.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1jkjvi-0005ii-KF; Mon, 15 Jun 2020 07:53:18 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 28ED530604B; Mon, 15 Jun 2020 09:53:13 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 107F021059BE3; Mon, 15 Jun 2020 09:53:13 +0200 (CEST) Date: Mon, 15 Jun 2020 09:53:13 +0200 From: Peter Zijlstra To: Fenghua Yu Subject: Re: [PATCH v2 12/12] x86/traps: Fix up invalid PASID Message-ID: <20200615075313.GJ2497@hirez.programming.kicks-ass.net> References: <1592008893-9388-1-git-send-email-fenghua.yu@intel.com> <1592008893-9388-13-git-send-email-fenghua.yu@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1592008893-9388-13-git-send-email-fenghua.yu@intel.com> Cc: Dave Hansen , H Peter Anvin , Dave Jiang , Ashok Raj , x86 , amd-gfx , Ingo Molnar , Ravi V Shankar , Yu-cheng Yu , Andrew Donnellan , Borislav Petkov , Thomas Gleixner , Tony Luck , linuxppc-dev , Felix Kuehling , linux-kernel , iommu@lists.linux-foundation.org, Jacob Jun Pan , Frederic Barrat , David Woodhouse X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On Fri, Jun 12, 2020 at 05:41:33PM -0700, Fenghua Yu wrote: > @@ -447,6 +458,18 @@ dotraplinkage void do_general_protection(struct pt_regs *regs, long error_code) > int ret; > > RCU_LOCKDEP_WARN(!rcu_is_watching(), "entry code didn't wake RCU"); > + > + /* > + * Perform the check for a user mode PASID exception before enable > + * interrupts. Doing this here ensures that the PASID MSR can be simply > + * accessed because the contents are known to be still associated > + * with the current process. > + */ > + if (user_mode(regs) && fixup_pasid_exception()) { > + cond_local_irq_enable(regs); > + return; OK, so we're done with the exception, lets enable interrupts? > + } _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu