public inbox for iommu@lists.linux-foundation.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Robin Murphy <robin.murphy@arm.com>
Cc: iommu@lists.linux-foundation.org, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] dma-debug: use named initializers for dir2name
Date: Mon, 20 Jul 2020 08:23:39 +0200	[thread overview]
Message-ID: <20200720062339.GB10878@lst.de> (raw)
In-Reply-To: <c31374eb-855a-839b-5d52-96bc93ca69f3@arm.com>

On Thu, Jul 16, 2020 at 05:12:30PM +0100, Robin Murphy wrote:
>> +static const char *dir2name[4] = {
>
> Nit: I think you can probably drop the explicit array size here.
>
> Otherwise, very welcome clarity!
>
> Reviewed-by: Robin Murphy <robin.murphy@arm.com>

Applied with the explicit array size removed.
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

      reply	other threads:[~2020-07-20  6:23 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-16 15:01 [PATCH] dma-debug: use named initializers for dir2name Christoph Hellwig
2020-07-16 16:12 ` Robin Murphy
2020-07-20  6:23   ` Christoph Hellwig [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200720062339.GB10878@lst.de \
    --to=hch@lst.de \
    --cc=iommu@lists.linux-foundation.org \
    --cc=robin.murphy@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox