Re: [PATCH 14/15] x86/numa: remove redundant iteration over memblock.reserved

Ingo Molnar
2020-07-28T11:31:35Z

* Mike Rapoport <rppt@kernel.org> wrote:

> On Tue, Jul 28, 2020 at 12:44:40PM +0200, Ingo Molnar wrote:
> >
> > * Mike Rapoport <rppt@kernel.org> wrote:
> >
> > > From: Mike Rapoport <rppt@linux.ibm.com>
> > >
> > > numa_clear_kernel_node_hotplug() function first traverses numa_meminfo
> > > regions to set node ID in memblock.reserved and than traverses
> > > memblock.reserved to update reserved_nodemask to include node IDs that were
> > > set in the first loop.
> > >
> > > Remove redundant traversal over memblock.reserved and update
> > > reserved_nodemask while iterating over numa_meminfo.
> > >
> > > Signed-off-by: Mike Rapoport <rppt@linux.ibm.com>
> > > ---
> > > arch/x86/mm/numa.c | 26 ++++++++++----------------
> > > 1 file changed, 10 insertions(+), 16 deletions(-)
> >
> > I suspect you'd like to carry this in the -mm tree?
>
> Yes.
>
> > Acked-by: Ingo Molnar <mingo@kernel.org>
>
> Thanks!

Assuming it is correct and works. :-)

Thanks,

Ingo