Re: [PATCH 1/2] dma-pool: fix coherent pool allocations for IOMMU mappings

Christoph Hellwig
2020-07-28T15:29:07Z

On Tue, Jul 28, 2020 at 04:56:29PM +0200, Nicolas Saenz Julienne wrote:
> > + phys = gen_pool_virt_to_phys(pool, addr);
> > + if (!phys_addr_ok(dev, phys, size)) {
>
> Shoudn't we check if phys_addr_ok() != NULL?

Yes, we should. This also means the system that causes problems for
Amit isn't using the iommu.