Re: [PATCH v3 4/8] of: unittest: Add test for of_dma_get_max_cpu_address()

Rob Herring
2020-10-14T22:04:46Z

On Wed, Oct 14, 2020 at 2:12 PM Nicolas Saenz Julienne
<nsaenzjulienne@suse.de> wrote:
>
> Introduce a test for of_dma_get_max_cup_address(), it uses the same DT
> data as the rest of dma-ranges unit tests.
>
> Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
> ---
> drivers/of/unittest.c | 20 ++++++++++++++++++++
> 1 file changed, 20 insertions(+)
>
> diff --git a/drivers/of/unittest.c b/drivers/of/unittest.c
> index 06cc988faf78..2cbf2a585c9f 100644
> --- a/drivers/of/unittest.c
> +++ b/drivers/of/unittest.c
> @@ -869,6 +869,25 @@ static void __init of_unittest_changeset(void)
> #endif
> }
>
> +static void __init of_unittest_dma_get_max_cpu_address(void)
> +{
> +#ifdef CONFIG_HAS_DMA

Can't the unittest run without this? I run the unittests under UML.

> + struct device_node *np;
> + phys_addr_t cpu_addr;
> +
> + np = of_find_node_by_path("/testcase-data/address-tests");
> + if (!np) {
> + pr_err("missing testcase data\n");
> + return;
> + }
> +
> + cpu_addr = of_dma_get_max_cpu_address(np);
> + unittest(cpu_addr == 0x50000000ULL,
> + "of_dma_get_max_cpu_address: wrong CPU addr %pad (expecting %llx)\n",
> + &cpu_addr, 0x50000000ULL);
> +#endif
> +}
> +
> static void __init of_unittest_dma_ranges_one(const char *path,
> u64 expect_dma_addr, u64 expect_paddr)
> {
> @@ -3266,6 +3285,7 @@ static int __init of_unittest(void)
> of_unittest_changeset();
> of_unittest_parse_interrupts();
> of_unittest_parse_interrupts_extended();
> + of_unittest_dma_get_max_cpu_address();
> of_unittest_parse_dma_ranges();
> of_unittest_pci_dma_ranges();
> of_unittest_match_node();
> --
> 2.28.0