Re: [PATCH] RDMA: Fix software RDMA drivers for dma mapping error

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3355 bytes --]

Hi Parav,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on rdma/for-next]
[also build test ERROR on v5.10-rc1 next-20201028]
[cannot apply to hch-configfs/for-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Parav-Pandit/RDMA-Fix-software-RDMA-drivers-for-dma-mapping-error/20201027-205440
base:   https://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git for-next
config: x86_64-rhel-8.3 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/cbe9509f0d3a076646d576c1d1f5adc59159316c
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Parav-Pandit/RDMA-Fix-software-RDMA-drivers-for-dma-mapping-error/20201027-205440
        git checkout cbe9509f0d3a076646d576c1d1f5adc59159316c
        # save the attached .config to linux build tree
        make W=1 ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/infiniband/sw/rxe/rxe_verbs.c: In function 'rxe_register_device':
>> drivers/infiniband/sw/rxe/rxe_verbs.c:1133:48: error: 'DMA_MASK_NONE' undeclared (first use in this function); did you mean 'CPU_MASK_NONE'?
    1133 |  err = dma_coerce_mask_and_coherent(&dev->dev, DMA_MASK_NONE);
         |                                                ^~~~~~~~~~~~~
         |                                                CPU_MASK_NONE
   drivers/infiniband/sw/rxe/rxe_verbs.c:1133:48: note: each undeclared identifier is reported only once for each function it appears in
--
   drivers/infiniband/sw/siw/siw_main.c: In function 'siw_device_create':
>> drivers/infiniband/sw/siw/siw_main.c:387:51: error: 'DMA_MASK_NONE' undeclared (first use in this function); did you mean 'CPU_MASK_NONE'?
     387 |  if (dma_coerce_mask_and_coherent(&base_dev->dev, DMA_MASK_NONE))
         |                                                   ^~~~~~~~~~~~~
         |                                                   CPU_MASK_NONE
   drivers/infiniband/sw/siw/siw_main.c:387:51: note: each undeclared identifier is reported only once for each function it appears in

vim +1133 drivers/infiniband/sw/rxe/rxe_verbs.c

  1115	
  1116	int rxe_register_device(struct rxe_dev *rxe, const char *ibdev_name)
  1117	{
  1118		int err;
  1119		struct ib_device *dev = &rxe->ib_dev;
  1120		struct crypto_shash *tfm;
  1121	
  1122		strlcpy(dev->node_desc, "rxe", sizeof(dev->node_desc));
  1123	
  1124		dev->node_type = RDMA_NODE_IB_CA;
  1125		dev->phys_port_cnt = 1;
  1126		dev->num_comp_vectors = num_possible_cpus();
  1127		dev->dev.parent = rxe_dma_device(rxe);
  1128		dev->local_dma_lkey = 0;
  1129		addrconf_addr_eui48((unsigned char *)&dev->node_guid,
  1130				    rxe->ndev->dev_addr);
  1131		dev->dev.dma_parms = &rxe->dma_parms;
  1132		dma_set_max_seg_size(&dev->dev, UINT_MAX);
> 1133		err = dma_coerce_mask_and_coherent(&dev->dev, DMA_MASK_NONE);

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 41020 bytes --]

[-- Attachment #3: Type: text/plain, Size: 156 bytes --]

_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu