From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 706D9C2D0A3 for ; Tue, 3 Nov 2020 13:56:32 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A2C37206F8 for ; Tue, 3 Nov 2020 13:56:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A2C37206F8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=8bytes.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 374ED870C7; Tue, 3 Nov 2020 13:56:31 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xNbBrKoi4ID9; Tue, 3 Nov 2020 13:56:30 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by hemlock.osuosl.org (Postfix) with ESMTP id C51468708E; Tue, 3 Nov 2020 13:56:30 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id AC7D8C088B; Tue, 3 Nov 2020 13:56:30 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by lists.linuxfoundation.org (Postfix) with ESMTP id 11EDBC0051 for ; Tue, 3 Nov 2020 13:56:30 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id E79BD86C3A for ; Tue, 3 Nov 2020 13:56:29 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jCbrifSlkFwU for ; Tue, 3 Nov 2020 13:56:29 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from theia.8bytes.org (8bytes.org [81.169.241.247]) by whitealder.osuosl.org (Postfix) with ESMTPS id 54527867CE for ; Tue, 3 Nov 2020 13:56:29 +0000 (UTC) Received: by theia.8bytes.org (Postfix, from userid 1000) id B62C0433; Tue, 3 Nov 2020 14:56:26 +0100 (CET) Date: Tue, 3 Nov 2020 14:56:25 +0100 From: Joerg Roedel To: Dan Carpenter Subject: Re: [PATCH] iommu: fix a check in iommu_check_bind_data() Message-ID: <20201103135625.GK22888@8bytes.org> References: <20201103101623.GA1127762@mwanda> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201103101623.GA1127762@mwanda> User-Agent: Mutt/1.10.1 (2018-07-13) Cc: Jean-Philippe Brucker , Jacob Pan , kernel-janitors@vger.kernel.org, iommu@lists.linux-foundation.org X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On Tue, Nov 03, 2020 at 01:16:23PM +0300, Dan Carpenter wrote: > The "data->flags" variable is a u64 so if one of the high 32 bits is > set the original code will allow it, but it should be rejected. The > fix is to declare "mask" as a u64 instead of a u32. > > Fixes: d90573812eea ("iommu/uapi: Handle data and argsz filled by users") > Signed-off-by: Dan Carpenter > --- > drivers/iommu/iommu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied for v5.10, thanks. _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu