From: Christoph Hellwig <hch@lst.de>
To: Jason Gunthorpe <jgg@ziepe.ca>
Cc: Zhu Yanjun <yanjunz@nvidia.com>,
Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>,
linux-rdma@vger.kernel.org, linux-pci@vger.kernel.org,
Mike Marciniszyn <mike.marciniszyn@cornelisnetworks.com>,
iommu@lists.linux-foundation.org,
Bjorn Helgaas <bhelgaas@google.com>,
Bernard Metzler <bmt@zurich.ibm.com>,
Logan Gunthorpe <logang@deltatee.com>
Subject: [PATCH 1/6] RMDA/sw: don't allow drivers using dma_virt_ops on highmem configs
Date: Thu, 5 Nov 2020 08:42:00 +0100 [thread overview]
Message-ID: <20201105074205.1690638-2-hch@lst.de> (raw)
In-Reply-To: <20201105074205.1690638-1-hch@lst.de>
dma_virt_ops requires that all pages have a kernel virtual address.
Introduce a INFINIBAND_VIRT_DMA Kconfig symbol that depends on !HIGHMEM
and a large enough dma_addr_t, and make all three driver depend on the
new symbol.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
drivers/infiniband/Kconfig | 6 ++++++
drivers/infiniband/sw/rdmavt/Kconfig | 3 ++-
drivers/infiniband/sw/rxe/Kconfig | 2 +-
drivers/infiniband/sw/siw/Kconfig | 1 +
4 files changed, 10 insertions(+), 2 deletions(-)
diff --git a/drivers/infiniband/Kconfig b/drivers/infiniband/Kconfig
index 32a51432ec4f73..81acaf5fb5be67 100644
--- a/drivers/infiniband/Kconfig
+++ b/drivers/infiniband/Kconfig
@@ -73,6 +73,12 @@ config INFINIBAND_ADDR_TRANS_CONFIGFS
This allows the user to config the default GID type that the CM
uses for each device, when initiaing new connections.
+config INFINIBAND_VIRT_DMA
+ bool
+ default y
+ depends on !HIGHMEM
+ depends on !64BIT || ARCH_DMA_ADDR_T_64BIT
+
if INFINIBAND_USER_ACCESS || !INFINIBAND_USER_ACCESS
source "drivers/infiniband/hw/mthca/Kconfig"
source "drivers/infiniband/hw/qib/Kconfig"
diff --git a/drivers/infiniband/sw/rdmavt/Kconfig b/drivers/infiniband/sw/rdmavt/Kconfig
index 9ef5f5ce1ff6b0..c8e268082952b0 100644
--- a/drivers/infiniband/sw/rdmavt/Kconfig
+++ b/drivers/infiniband/sw/rdmavt/Kconfig
@@ -1,7 +1,8 @@
# SPDX-License-Identifier: GPL-2.0-only
config INFINIBAND_RDMAVT
tristate "RDMA verbs transport library"
- depends on X86_64 && ARCH_DMA_ADDR_T_64BIT
+ depends on INFINIBAND_VIRT_DMA
+ depends on X86_64
depends on PCI
select DMA_VIRT_OPS
help
diff --git a/drivers/infiniband/sw/rxe/Kconfig b/drivers/infiniband/sw/rxe/Kconfig
index a0c6c7dfc1814f..8810bfa680495a 100644
--- a/drivers/infiniband/sw/rxe/Kconfig
+++ b/drivers/infiniband/sw/rxe/Kconfig
@@ -2,7 +2,7 @@
config RDMA_RXE
tristate "Software RDMA over Ethernet (RoCE) driver"
depends on INET && PCI && INFINIBAND
- depends on !64BIT || ARCH_DMA_ADDR_T_64BIT
+ depends on INFINIBAND_VIRT_DMA
select NET_UDP_TUNNEL
select CRYPTO_CRC32
select DMA_VIRT_OPS
diff --git a/drivers/infiniband/sw/siw/Kconfig b/drivers/infiniband/sw/siw/Kconfig
index b622fc62f2cd6d..3450ba5081df51 100644
--- a/drivers/infiniband/sw/siw/Kconfig
+++ b/drivers/infiniband/sw/siw/Kconfig
@@ -1,6 +1,7 @@
config RDMA_SIW
tristate "Software RDMA over TCP/IP (iWARP) driver"
depends on INET && INFINIBAND && LIBCRC32C
+ depends on INFINIBAND_VIRT_DMA
select DMA_VIRT_OPS
help
This driver implements the iWARP RDMA transport over
--
2.28.0
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2020-11-05 7:46 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-05 7:41 remove dma_virt_ops v2 Christoph Hellwig
2020-11-05 7:42 ` Christoph Hellwig [this message]
2020-11-05 12:15 ` [PATCH 1/6] RMDA/sw: don't allow drivers using dma_virt_ops on highmem configs Robin Murphy
2020-11-05 17:00 ` Christoph Hellwig
2020-11-05 14:41 ` Jason Gunthorpe
2020-11-05 15:29 ` Robin Murphy
2020-11-05 17:03 ` Christoph Hellwig
2020-11-05 20:32 ` Bernard Metzler
2020-11-05 7:42 ` [PATCH 2/6] RDMA/core: remove ib_dma_{alloc,free}_coherent Christoph Hellwig
2020-11-05 7:42 ` [PATCH 3/6] RDMA/core: remove use of dma_virt_ops Christoph Hellwig
2020-11-05 14:34 ` Jason Gunthorpe
2020-11-05 17:09 ` Christoph Hellwig
2020-11-05 17:52 ` Jason Gunthorpe
2020-11-05 17:58 ` Jason Gunthorpe
2020-11-06 14:18 ` Christoph Hellwig
2020-11-06 10:01 ` Christoph Hellwig
2020-11-05 7:42 ` [PATCH 4/6] PCI/P2PDMA: Remove the DMA_VIRT_OPS hacks Christoph Hellwig
2020-11-05 14:34 ` Jason Gunthorpe
2020-11-05 17:08 ` Christoph Hellwig
2020-11-05 17:23 ` Jason Gunthorpe
2020-11-05 17:29 ` Christoph Hellwig
2020-11-05 17:39 ` Jason Gunthorpe
2020-11-05 17:43 ` Christoph Hellwig
2020-11-05 17:56 ` Jason Gunthorpe
2020-11-05 7:42 ` [PATCH 5/6] PCI/P2PDMA: Cleanup __pci_p2pdma_map_sg a bit Christoph Hellwig
2020-11-05 7:42 ` [PATCH 6/6] dma-mapping: remove dma_virt_ops Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201105074205.1690638-2-hch@lst.de \
--to=hch@lst.de \
--cc=bhelgaas@google.com \
--cc=bmt@zurich.ibm.com \
--cc=dennis.dalessandro@cornelisnetworks.com \
--cc=iommu@lists.linux-foundation.org \
--cc=jgg@ziepe.ca \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=logang@deltatee.com \
--cc=mike.marciniszyn@cornelisnetworks.com \
--cc=yanjunz@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox