From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6424C433E0 for ; Mon, 8 Feb 2021 16:10:54 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4BBD764E6F for ; Mon, 8 Feb 2021 16:10:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4BBD764E6F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 1DF1E20356; Mon, 8 Feb 2021 16:10:54 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id B3yRtqusdduQ; Mon, 8 Feb 2021 16:10:53 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by silver.osuosl.org (Postfix) with ESMTP id 38F8720797; Mon, 8 Feb 2021 16:10:52 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 266AAC0174; Mon, 8 Feb 2021 16:10:52 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists.linuxfoundation.org (Postfix) with ESMTP id 5601CC013A for ; Mon, 8 Feb 2021 16:10:50 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 4E5F1870B6 for ; Mon, 8 Feb 2021 16:10:50 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fhqhbXB-cZz6 for ; Mon, 8 Feb 2021 16:10:48 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by hemlock.osuosl.org (Postfix) with ESMTPS id 8EDC2870B5 for ; Mon, 8 Feb 2021 16:10:48 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 0A05D67373; Mon, 8 Feb 2021 17:10:44 +0100 (CET) Date: Mon, 8 Feb 2021 17:10:43 +0100 From: Christoph Hellwig To: "Maciej W. Rozycki" Subject: Re: [PATCH 5/6] driver core: lift dma_default_coherent into common code Message-ID: <20210208161043.GA14083@lst.de> References: <20210208145024.3320420-1-hch@lst.de> <20210208145024.3320420-6-hch@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Cc: Thomas Bogendoerfer , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, iommu@lists.linux-foundation.org, Christoph Hellwig X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On Mon, Feb 08, 2021 at 04:57:33PM +0100, Maciej W. Rozycki wrote: > > diff --git a/arch/mips/mti-malta/malta-setup.c b/arch/mips/mti-malta/malta-setup.c > > index e98cc977a735b2..f8c9663e7faa10 100644 > > --- a/arch/mips/mti-malta/malta-setup.c > > +++ b/arch/mips/mti-malta/malta-setup.c > > @@ -143,7 +143,7 @@ static void __init plat_setup_iocoherency(void) > > pr_crit("IOCU OPERATION DISABLED BY SWITCH - DEFAULTING TO SW IO COHERENCY\n"); > > } > > > > - if (supported) > > + if (supported) { > > if (dma_force_noncoherent) { > > pr_info("Hardware DMA cache coherency disabled\n"); > > return; > > I think this has to go with 1/6; otherwise compilation breaks between > then and now AFAICT. Indeed. > Do you need to have this verified anyhow? I only have a non-coherent 5Kc > Malta though. If you get a chance to test this logic, that would be great. _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu