From: Will Deacon <will@kernel.org>
To: Andrey Ryabinin <arbn@yandex-team.com>
Cc: valesini@yandex-team.ru, linux-kernel@vger.kernel.org,
stable@vger.kernel.org, iommu@lists.linux-foundation.org,
Qian Cai <cai@lca.pw>
Subject: Re: [PATCH] iommu/amd: Fix sleeping in atomic in increase_address_space()
Date: Wed, 17 Feb 2021 18:10:02 +0000 [thread overview]
Message-ID: <20210217181002.GC4304@willie-the-truck> (raw)
In-Reply-To: <20210217143004.19165-1-arbn@yandex-team.com>
On Wed, Feb 17, 2021 at 05:30:04PM +0300, Andrey Ryabinin wrote:
> increase_address_space() calls get_zeroed_page(gfp) under spin_lock with
> disabled interrupts. gfp flags passed to increase_address_space() may allow
> sleeping, so it comes to this:
>
> BUG: sleeping function called from invalid context at mm/page_alloc.c:4342
> in_atomic(): 1, irqs_disabled(): 1, pid: 21555, name: epdcbbf1qnhbsd8
>
> Call Trace:
> dump_stack+0x66/0x8b
> ___might_sleep+0xec/0x110
> __alloc_pages_nodemask+0x104/0x300
> get_zeroed_page+0x15/0x40
> iommu_map_page+0xdd/0x3e0
> amd_iommu_map+0x50/0x70
> iommu_map+0x106/0x220
> vfio_iommu_type1_ioctl+0x76e/0x950 [vfio_iommu_type1]
> do_vfs_ioctl+0xa3/0x6f0
> ksys_ioctl+0x66/0x70
> __x64_sys_ioctl+0x16/0x20
> do_syscall_64+0x4e/0x100
> entry_SYSCALL_64_after_hwframe+0x44/0xa9
>
> Fix this by moving get_zeroed_page() out of spin_lock/unlock section.
>
> Fixes: 754265bcab ("iommu/amd: Fix race in increase_address_space()")
> Signed-off-by: Andrey Ryabinin <arbn@yandex-team.com>
> Cc: <stable@vger.kernel.org>
> ---
> drivers/iommu/amd/iommu.c | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
Acked-by: Will Deacon <will@kernel.org>
Will
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2021-02-17 18:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-17 14:30 [PATCH] iommu/amd: Fix sleeping in atomic in increase_address_space() Andrey Ryabinin
2021-02-17 18:10 ` Will Deacon [this message]
2021-03-04 12:19 ` Joerg Roedel
2021-03-05 8:18 ` Andrey Ryabinin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210217181002.GC4304@willie-the-truck \
--to=will@kernel.org \
--cc=arbn@yandex-team.com \
--cc=cai@lca.pw \
--cc=iommu@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=valesini@yandex-team.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox