Re: [RFC PATCH v2 07/11] dma-mapping: Add flags to dma_map_ops to indicate PCI P2PDMA support

Ira Weiny
2021-03-13T02:37:04Z

On Thu, Mar 11, 2021 at 04:31:37PM -0700, Logan Gunthorpe wrote:

> +int dma_pci_p2pdma_supported(struct device *dev)
^^^
bool?

> +{
> + const struct dma_map_ops *ops = get_dma_ops(dev);
> +
> + return !ops || ops->flags & DMA_F_PCI_P2PDMA_SUPPORTED;

Is this logic correct? I would have expected.

return (ops && ops->flags & DMA_F_PCI_P2PDMA_SUPPORTED);

Ira